external/aurweb
0
0
Fork 0
mirror of https://gitlab.archlinux.org/archlinux/aurweb.git synced 2025-02-03 10:43:03 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix more PHP 7.4 warnings

Browse source 
The try_login() function documents it returns an array containing an
'error' key, and our only caller *only* consults the 'error' key. Then
the function returns null instead of an array, if the login succeeded!

I question why we bother returning the new SID if we never use it,
surely we could either return the error or return default null. But, for
now, I'm just going to fix it to return what it's actually supposed to,
without changing the API.

Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
This commit is contained in:
Eli Schwartz 2020-02-12 15:16:38 -05:00 • committed by Lukas Fleischer
parent 5ca1e271f9
commit 050b08081a
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
web/lib/acctfuncs.inc.php
View file

@ -659,6 +659,7 @@ function try_login() {
}
header("Location: " . get_uri($referer));
$login_error = "";
return array('SID' => $new_sid, 'error' => null);
}
/**