external/aurweb
0
0
Fork 0
mirror of https://gitlab.archlinux.org/archlinux/aurweb.git synced 2025-02-03 10:43:03 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Be explicit about accepted requests in emails

Browse source 
When sending notification emails after closing a request, be explicit
about whether the request has been accepted or not.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
This commit is contained in:
Lukas Fleischer 2014-07-01 20:06:41 +02:00
parent 707b1bb878
commit 0d513e1468
3 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
web/html/pkgbase.php
View file

@ -99,7 +99,7 @@ if (check_token()) {
} elseif (current_action("do_FileRequest")) { } elseif (current_action("do_FileRequest")) {
list($ret, $output) = pkgreq_file($ids, $_POST['type'], $_POST['merge_into'], $_POST['comments']); list($ret, $output) = pkgreq_file($ids, $_POST['type'], $_POST['merge_into'], $_POST['comments']);
} elseif (current_action("do_CloseRequest")) { } elseif (current_action("do_CloseRequest")) {
list($ret, $output) = pkgreq_close($_POST['reqid']); list($ret, $output) = pkgreq_close($_POST['reqid'], false);
} }
if (isset($_REQUEST['comment'])) { if (isset($_REQUEST['comment'])) {

4
web/lib/pkgbasefuncs.inc.php
View file

@ -540,7 +540,7 @@ function pkgbase_delete ($atype, $base_ids, $merge_base_id, $via) {
$dbh->exec($q); $dbh->exec($q);
if ($via) { if ($via) {
pkgreq_close(intval($via)); pkgreq_close(intval($via), true);
} }
return array(true, __("The selected packages have been deleted.")); return array(true, __("The selected packages have been deleted."));
@ -598,7 +598,7 @@ function pkgbase_adopt ($atype, $base_ids, $action=true, $via) {
$dbh->exec($q); $dbh->exec($q);
if ($via) { if ($via) {
pkgreq_close(intval($via)); pkgreq_close(intval($via), true);
} }
if ($action) { if ($action) {

7
web/lib/pkgreqfuncs.inc.php
View file

@ -126,10 +126,11 @@ function pkgreq_file($ids, $type, $merge_into, $comments) {
* @global string $AUR_LOCATION The AUR's URL used for notification e-mails * @global string $AUR_LOCATION The AUR's URL used for notification e-mails
* @global string $AUR_REQUEST_ML The request notification mailing list * @global string $AUR_REQUEST_ML The request notification mailing list
* @param int $id The package request to close * @param int $id The package request to close
* @param bool $accepted True if the request has been accepted, false otherwise
* *
* @return array Tuple of success/failure indicator and error message * @return array Tuple of success/failure indicator and error message
*/ */
function pkgreq_close($id) { function pkgreq_close($id, $accepted) {
global $AUR_LOCATION; global $AUR_LOCATION;
global $AUR_REQUEST_ML; global $AUR_REQUEST_ML;
@ -167,7 +168,9 @@ function pkgreq_close($id) {
* user who posted the comment was in. * user who posted the comment was in.
*/ */
$username = username_from_sid($_COOKIE['AURSID']); $username = username_from_sid($_COOKIE['AURSID']);
$body = $username . " [1] closed request #" . intval($id) . ".\n\n" . $body = "Request #" . intval($id) . " has been " .
($accepted ? "accepted" : "closed") . " by " .
$username . " [1].\n\n" .
"[1] " . $AUR_LOCATION . get_user_uri($username) . "\n"; "[1] " . $AUR_LOCATION . get_user_uri($username) . "\n";
$body = wordwrap($body, 70); $body = wordwrap($body, 70);
$headers = "MIME-Version: 1.0\r\n" . $headers = "MIME-Version: 1.0\r\n" .