From 0e82916b0a149e81b0936eb5edcfd387798e9481 Mon Sep 17 00:00:00 2001
From: Jelle van der Waa <jelle@archlinux.org>
Date: Tue, 2 Aug 2022 16:30:45 +0200
Subject: [PATCH] fix(python): don't show maintainer link for non logged in
 users

Show a plain maintainer text for non logged in users like the submitted,
last packager.

Closes #373
---
 templates/partials/packages/details.html | 5 ++++-
 test/test_pkgbase_routes.py              | 6 +++---
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/templates/partials/packages/details.html b/templates/partials/packages/details.html
index e0eda54c..771b311d 100644
--- a/templates/partials/packages/details.html
+++ b/templates/partials/packages/details.html
@@ -108,7 +108,7 @@
     <tr class="pkgmaint">
         <th>{{ "Maintainer" | tr }}:</th>
         <td>
-            {% if pkgbase.Maintainer %}
+            {% if request.user.is_authenticated() and pkgbase.Maintainer %}
                 <a href="/account/{{ pkgbase.Maintainer.Username }}">
                     {{ pkgbase.Maintainer.Username }}
                 </a>
@@ -118,6 +118,9 @@
                 {% endif %}
             {% else %}
                 {{ pkgbase.Maintainer.Username | default("None" | tr) }}
+                {% if comaintainers %}
+		     ({{ comaintainers|join(', ') }})
+                {% endif %}
             {% endif %}
         </td>
     </tr>
diff --git a/test/test_pkgbase_routes.py b/test/test_pkgbase_routes.py
index a152c590..dae43e37 100644
--- a/test/test_pkgbase_routes.py
+++ b/test/test_pkgbase_routes.py
@@ -272,9 +272,9 @@ def test_pkgbase_maintainer(client: TestClient, user: User, maintainer: User,
     root = parse_root(resp.text)
 
     maint = root.xpath('//table[@id="pkginfo"]/tr[@class="pkgmaint"]/td')[0]
-    maint, comaint = maint.xpath('./a')
-    assert maint.text.strip() == maintainer.Username
-    assert comaint.text.strip() == user.Username
+    maint, comaint = maint.text.strip().split()
+    assert maint == maintainer.Username
+    assert comaint == f'({user.Username})'
 
 
 def test_pkgbase_voters(client: TestClient, tu_user: User, package: Package):