From 1c11c901a2d389bf497e886c990b634a70a4df7a Mon Sep 17 00:00:00 2001
From: moson-mo <mo-son@mailbox.org>
Date: Sat, 10 Jun 2023 09:40:35 +0200
Subject: [PATCH] feat: switch requests filter for pkgname to "contains"

Use "contains" filtering instead of an exact match
when a package name filter is given.

This makes it easier to find requests for a "group" of packages.

Signed-off-by: moson-mo <mo-son@mailbox.org>
---
 aurweb/routers/requests.py |  4 ++--
 test/test_requests.py      | 20 +++++++++++++++++---
 2 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/aurweb/routers/requests.py b/aurweb/routers/requests.py
index 585dc157..4cfda269 100644
--- a/aurweb/routers/requests.py
+++ b/aurweb/routers/requests.py
@@ -99,9 +99,9 @@ async def requests(
         in_filters.append(REJECTED_ID)
     filtered = query.filter(PackageRequest.Status.in_(in_filters))
 
-    # Name filter
+    # Name filter (contains)
     if filter_pkg_name:
-        filtered = filtered.filter(PackageBase.Name == filter_pkg_name)
+        filtered = filtered.filter(PackageBase.Name.like(f"%{filter_pkg_name}%"))
 
     # Additionally filter for requests made from package maintainer
     if filter_maintainer_requests:
diff --git a/test/test_requests.py b/test/test_requests.py
index 7ddb76a0..eb88cd94 100644
--- a/test/test_requests.py
+++ b/test/test_requests.py
@@ -925,14 +925,28 @@ def test_requests_with_package_name_filter(
         request.cookies = cookies
         resp = request.get(
             "/requests",
-            params={"filter_pkg_name": packages[0].PackageBase.Name},
+            params={"filter_pkg_name": "kg_1"},
         )
     assert resp.status_code == int(HTTPStatus.OK)
 
     root = parse_root(resp.text)
     rows = root.xpath('//table[@class="results"]/tbody/tr')
-    # We only expect 1 request for our first package
-    assert len(rows) == 1
+    # We expect 11 requests for all packages containing "kg_1"
+    assert len(rows) == 11
+
+    # test as TU, no results
+    with client as request:
+        request.cookies = cookies
+        resp = request.get(
+            "/requests",
+            params={"filter_pkg_name": "x"},
+        )
+    assert resp.status_code == int(HTTPStatus.OK)
+
+    root = parse_root(resp.text)
+    rows = root.xpath('//table[@class="results"]/tbody/tr')
+    # We expect 0 requests since we don't have anything containing "x"
+    assert len(rows) == 0
 
     # test as regular user, not related to our package
     cookies = {"AURSID": user2.login(Request(), "testPassword")}