test(routers.packages): fix package view dependency test

Signed-off-by: Kevin Morris <kevr@0cost.org>
This commit is contained in:
Kevin Morris 2021-12-26 17:03:16 -08:00
parent 84a54bb6e6
commit 2baf061b96
No known key found for this signature in database
GPG key ID: F7E46DED420788F3

View file

@ -455,13 +455,13 @@ def test_package_dependencies(client: TestClient, maintainer: User,
# And... a checkdepends! # And... a checkdepends!
check_dep_pkg = create_package("test-dep-3", maintainer) check_dep_pkg = create_package("test-dep-3", maintainer)
check_dep = create_package_dep(package, check_dep_pkg.Name, create_package_dep(package, check_dep_pkg.Name,
dep_type_name="checkdepends") dep_type_name="checkdepends")
# Geez. Just stop. This is optdepends. # Geez. Just stop. This is optdepends.
opt_dep_pkg = create_package("test-dep-4", maintainer) opt_dep_pkg = create_package("test-dep-4", maintainer)
opt_dep = create_package_dep(package, opt_dep_pkg.Name, create_package_dep(package, opt_dep_pkg.Name,
dep_type_name="optdepends") dep_type_name="optdepends")
# Heh. Another optdepends to test one with a description. # Heh. Another optdepends to test one with a description.
opt_desc_dep_pkg = create_package("test-dep-5", maintainer) opt_desc_dep_pkg = create_package("test-dep-5", maintainer)
@ -475,7 +475,7 @@ def test_package_dependencies(client: TestClient, maintainer: User,
# Create an official provider record. # Create an official provider record.
db.create(OfficialProvider, Name="test-dep-99", db.create(OfficialProvider, Name="test-dep-99",
Repo="core", Provides="test-dep-99") Repo="core", Provides="test-dep-99")
official_dep = create_package_dep(package, "test-dep-99") create_package_dep(package, "test-dep-99")
# Also, create a provider who provides our test-dep-99. # Also, create a provider who provides our test-dep-99.
provider = create_package("test-provider", maintainer) provider = create_package("test-provider", maintainer)
@ -485,25 +485,25 @@ def test_package_dependencies(client: TestClient, maintainer: User,
resp = request.get(package_endpoint(package)) resp = request.get(package_endpoint(package))
assert resp.status_code == int(HTTPStatus.OK) assert resp.status_code == int(HTTPStatus.OK)
# Let's make sure all the non-broken deps are ordered as we expect.
expected = list(filter(
lambda e: e.is_package(),
package.package_dependencies.order_by(
PackageDependency.DepTypeID.asc(),
PackageDependency.DepName.asc()
).all()
))
root = parse_root(resp.text) root = parse_root(resp.text)
expected = [
dep.DepName,
make_dep.DepName,
check_dep.DepName,
opt_dep.DepName,
opt_desc_dep.DepName,
official_dep.DepName
]
pkgdeps = root.findall('.//ul[@id="pkgdepslist"]/li/a') pkgdeps = root.findall('.//ul[@id="pkgdepslist"]/li/a')
for i, expectation in enumerate(reversed(expected)): for i, expectation in enumerate(expected):
assert pkgdeps[i].text.strip() == expectation assert pkgdeps[i].text.strip() == expectation.DepName
# Let's make sure the DepArch was displayed for our target make dep. # Let's make sure the DepArch was displayed for our target make dep.
arch = root.findall('.//ul[@id="pkgdepslist"]/li')[-2] arch = root.findall('.//ul[@id="pkgdepslist"]/li')[3]
arch = arch.xpath('./em')[0] arch = arch.xpath('./em')[0]
assert arch.text.strip() == "(make, x86_64)" assert arch.text.strip() == "(make, x86_64)"
# And let's make sure that the broken package was displayed.
broken_node = root.find('.//ul[@id="pkgdepslist"]/li/span') broken_node = root.find('.//ul[@id="pkgdepslist"]/li/span')
assert broken_node.text.strip() == broken_dep.DepName assert broken_node.text.strip() == broken_dep.DepName