external/aurweb
0
0
Fork 0
mirror of https://gitlab.archlinux.org/archlinux/aurweb.git synced 2025-02-03 10:43:03 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix XSS vulnerabilities in package comment templates.

Browse source 
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
This commit is contained in:
Lukas Fleischer 2011-03-30 10:49:51 +02:00
parent 11366b8a1a
commit 3aa2240b7d
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
web/template/pkg_comment_form.php
View file

@ -50,14 +50,14 @@ if (isset($_REQUEST['comment'])) {
# Prompt visitor for comment # Prompt visitor for comment
?> ?>
<div class="pgbox"> <div class="pgbox">
<form action='<?php echo $_SERVER['PHP_SELF'] . '?ID=' . $_REQUEST['ID'] ?>' method='post'> <form action='<?php echo $_SERVER['REQUEST_URI'] ?>' method='post'>
<div style="padding: 1%"> <div style="padding: 1%">
<?php <?php
if (isset($_REQUEST['comment'])) { if (isset($_REQUEST['comment'])) {
echo '<b>' . __('Comment has been added.') . '</b>'; echo '<b>' . __('Comment has been added.') . '</b>';
} }
?> ?>
<input type='hidden' name='ID' value="<?php echo $_REQUEST['ID'] ?>" /> <input type='hidden' name='ID' value="<?php echo intval($_REQUEST['ID']) ?>" />
<?php echo __('Enter your comment below.') ?><br /> <?php echo __('Enter your comment below.') ?><br />
<textarea name='comment' cols='80' rows='10' style="width: 100%"></textarea><br /> <textarea name='comment' cols='80' rows='10' style="width: 100%"></textarea><br />
<input type='submit' value="<?php echo __("Submit") ?>" /> <input type='submit' value="<?php echo __("Submit") ?>" />

2
web/template/pkg_comments.php
View file

@ -39,7 +39,7 @@ while (list($indx, $carr) = each($comments)) { ?>
$count = package_comments_count($_GET['ID']); $count = package_comments_count($_GET['ID']);
if ($count > 10 && !isset($_GET['comments'])) { if ($count > 10 && !isset($_GET['comments'])) {
echo '<div class="pgbox">'; echo '<div class="pgbox">';
echo '<a href="'. $_SERVER['PHP_SELF'] . '?ID=' . $_REQUEST['ID'] . '&comments=all">'. __('Show all %s comments', $count) . '</a>'; echo '<a href="'. $_SERVER['REQUEST_URI'] . '&comments=all">'. __('Show all %s comments', $count) . '</a>';
echo '</div>'; echo '</div>';
} }
?> ?>