Fix category selection

Add a package ID parameter to pkg_change_category() instead of relying
on the "ID" or "N" GET parameters.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
This commit is contained in:
Lukas Fleischer 2012-09-18 16:09:09 +02:00
parent c959d95fb1
commit 3b1dad229b
2 changed files with 2 additions and 10 deletions

View file

@ -89,7 +89,7 @@ if (check_token()) {
} elseif (current_action("do_DeleteComment")) {
$output = pkg_delete_comment($atype);
} elseif (current_action("do_ChangeCategory")) {
$output = pkg_change_category($atype);
$output = pkg_change_category($pkgid, $atype);
}
}

View file

@ -1206,7 +1206,7 @@ function pkg_delete_comment($atype, $dbh=NULL) {
* @param string $atype Account type, output of account_from_sid
* @return string Translated error or success message
*/
function pkg_change_category($atype, $dbh=NULL) {
function pkg_change_category($pid, $atype, $dbh=NULL) {
if (!$atype) {
return __("You must be logged in before you can edit package information.");
}
@ -1226,14 +1226,6 @@ function pkg_change_category($atype, $dbh=NULL) {
return __("Invalid category ID.");
}
if (isset($_GET["ID"])) {
$pid = $_GET["ID"];
} elseif (isset($_GET["N"])) {
$pid = pkgid_from_name($_GET["N"]);
} else {
return __("Missing package ID.");
}
# Verify package ownership
$q = "SELECT Packages.MaintainerUID ";
$q.= "FROM Packages ";