Implement SSO logout

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
This commit is contained in:
Frédéric Mangano-Tarumi 2020-07-14 15:35:05 +02:00 committed by Lukas Fleischer
parent d12ea08fca
commit 4d0f2d2279
2 changed files with 31 additions and 1 deletions

View file

@ -1,6 +1,8 @@
import time
import uuid
from urllib.parse import urlencode
import fastapi
from authlib.integrations.starlette_client import OAuth
@ -82,3 +84,19 @@ async def authenticate(request: Request, conn=Depends(aurweb.db.connect)):
else:
# Weve got a severe integrity violation.
raise Exception("Multiple accounts found for SSO account " + sub)
@router.get("/sso/logout")
async def logout():
"""
Disconnect the user from the SSO provider, potentially affecting every
other Arch service. AUR logout is performed by `/logout`, before it
redirects to `/sso/logout`.
Based on the OpenID Connect Session Management specification:
https://openid.net/specs/openid-connect-session-1_0.html#RPLogout
"""
metadata = await oauth.sso.load_server_metadata()
# TODO Supply id_token_hint to the end session endpoint.
query = urlencode({'post_logout_redirect_uri': aurweb.config.get('options', 'aur_location')})
return RedirectResponse(metadata["end_session_endpoint"] + '?' + query)

View file

@ -5,16 +5,28 @@ set_include_path(get_include_path() . PATH_SEPARATOR . '../lib');
include_once("aur.inc.php"); # access AUR common functions
include_once("acctfuncs.inc.php"); # access AUR common functions
$redirect_uri = '/';
# if they've got a cookie, log them out - need to do this before
# sending any HTML output.
#
if (isset($_COOKIE["AURSID"])) {
$uid = uid_from_sid($_COOKIE['AURSID']);
delete_session_id($_COOKIE["AURSID"]);
# setting expiration to 1 means '1 second after midnight January 1, 1970'
setcookie("AURSID", "", 1, "/", null, !empty($_SERVER['HTTPS']), true);
unset($_COOKIE['AURSID']);
clear_expired_sessions();
# If the account is linked to an SSO account, disconnect the user from the SSO too.
if (isset($uid)) {
$dbh = DB::connect();
$sso_account_id = $dbh->query("SELECT SSOAccountID FROM Users WHERE ID = " . $dbh->quote($uid))
->fetchColumn();
if ($sso_account_id)
$redirect_uri = '/sso/logout';
}
}
header('Location: /');
header("Location: $redirect_uri");