external/aurweb
0
0
Fork 0
mirror of https://gitlab.archlinux.org/archlinux/aurweb.git synced 2025-02-03 10:43:03 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(rpc): correct URLPath in package results

Browse source 
This was incorrectly using the particular Package record's name
to format options.snapshot_uri in order to produce URLPath.

It should, instead, use the PackageBase record's name, which
this commit resolves.

Bug reported by thomy2000

Closes #382

Signed-off-by: Kevin Morris <kevr@0cost.org>
This commit is contained in:
Kevin Morris 2022-08-15 10:06:44 -07:00
parent edacde48e5
commit 801df832e5
No known key found for this signature in database
GPG key ID: F7E46DED420788F3
2 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
aurweb/rpc.py
View file

@ -138,7 +138,7 @@ class RPC:
"Version": package.Version,
"Description": package.Description,
"URL": package.URL,
"URLPath": snapshot_uri % package.Name,
"URLPath": snapshot_uri % package.PackageBaseName,
"NumVotes": package.NumVotes,
"Popularity": pop,
"OutOfDate": package.OutOfDateTS,

22
test/test_rpc.py
View file

@ -297,6 +297,28 @@ def test_rpc_singular_info(client: TestClient,
assert response_data == expected_data
def test_rpc_split_package_urlpath(client: TestClient, user: User):
with db.begin():
pkgbase = db.create(PackageBase, Name="pkg",
Maintainer=user, Packager=user)
pkgs = [
db.create(Package, PackageBase=pkgbase, Name="pkg_1"),
db.create(Package, PackageBase=pkgbase, Name="pkg_2"),
]
with client as request:
response = request.get("/rpc", params={
"v": 5,
"type": "info",
"arg": [pkgs[0].Name],
})
data = orjson.loads(response.text)
snapshot_uri = config.get("options", "snapshot_uri")
urlpath = data.get("results")[0].get("URLPath")
assert urlpath == (snapshot_uri % pkgbase.Name)
def test_rpc_nonexistent_package(client: TestClient):
# Make dummy request.
with client as request: