Allow package co-maintainers to pin comments

Implements FS#56255.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
This commit is contained in:
Lukas Fleischer 2017-11-06 16:57:12 +01:00
parent e2fa5ea6fa
commit 8c98db0b82

View file

@ -85,8 +85,9 @@ function can_edit_comment_array($comment) {
/** /**
* Determine if the user can pin a specific package comment * Determine if the user can pin a specific package comment
* *
* Only the Package Maintainer, Trusted Users, and Developers can pin * Only the Package Maintainer, Package Co-maintainers, Trusted Users, and
* comments. This function is used for the backend side of comment pinning. * Developers can pin comments. This function is used for the backend side of
* comment pinning.
* *
* @param string $comment_id The comment ID in the database * @param string $comment_id The comment ID in the database
* *
@ -97,6 +98,11 @@ function can_pin_comment($comment_id=0) {
$q = "SELECT MaintainerUID FROM PackageBases AS pb "; $q = "SELECT MaintainerUID FROM PackageBases AS pb ";
$q.= "LEFT JOIN PackageComments AS pc ON pb.ID = pc.PackageBaseID "; $q.= "LEFT JOIN PackageComments AS pc ON pb.ID = pc.PackageBaseID ";
$q.= "WHERE pc.ID = " . intval($comment_id) . " ";
$q.= "UNION ";
$q = "SELECT pcm.UsersID FROM PackageComaintainers AS pcm ";
$q.= "LEFT JOIN PackageComments AS pc ";
$q.= "ON pcm.PackageBaseID = pc.PackageBaseID ";
$q.= "WHERE pc.ID = " . intval($comment_id); $q.= "WHERE pc.ID = " . intval($comment_id);
$result = $dbh->query($q); $result = $dbh->query($q);
@ -104,16 +110,17 @@ function can_pin_comment($comment_id=0) {
return false; return false;
} }
$uid = $result->fetch(PDO::FETCH_COLUMN, 0); $uids = $result->fetchAll(PDO::FETCH_COLUMN, 0);
return has_credential(CRED_COMMENT_PIN, array($uid)); return has_credential(CRED_COMMENT_PIN, $uids);
} }
/** /**
* Determine if the user can edit a specific package comment using an array * Determine if the user can edit a specific package comment using an array
* *
* Only the Package Maintainer, Trusted Users, and Developers can pin * Only the Package Maintainer, Package Co-maintainers, Trusted Users, and
* comments. This function is used for the frontend side of comment pinning. * Developers can pin comments. This function is used for the frontend side of
* comment pinning.
* *
* @param array $comment All database information relating a specific comment * @param array $comment All database information relating a specific comment
* *