external/aurweb
0
0
Fork 0
mirror of https://gitlab.archlinux.org/archlinux/aurweb.git synced 2025-02-03 10:43:03 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: ...do not add to ActiveTUs when voting on a proposal

Browse source 
Straight up bug.

Closes #324

Signed-off-by: Kevin Morris <kevr@0cost.org>
This commit is contained in:
Kevin Morris 2022-02-25 19:24:29 -08:00
parent b63ac7ce91
commit 9204b76110
No known key found for this signature in database
GPG key ID: F7E46DED420788F3
2 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
aurweb/routers/trusted_user.py
View file

@ -220,7 +220,6 @@ async def trusted_user_proposal_post(request: Request, proposal: int,
with db.begin(): with db.begin():
vote = db.create(models.TUVote, User=request.user, VoteInfo=voteinfo) vote = db.create(models.TUVote, User=request.user, VoteInfo=voteinfo)
voteinfo.ActiveTUs += 1
context["error"] = "You've already voted for this proposal." context["error"] = "You've already voted for this proposal."
return render_proposal(request, context, proposal, voteinfo, voters, vote) return render_proposal(request, context, proposal, voteinfo, voters, vote)

2
test/test_trusted_user_routes.py
View file

@ -650,7 +650,6 @@ def test_tu_proposal_vote(client, proposal):
# Store the current related values. # Store the current related values.
yes = voteinfo.Yes yes = voteinfo.Yes
active_tus = voteinfo.ActiveTUs
cookies = {"AURSID": tu_user.login(Request(), "testPassword")} cookies = {"AURSID": tu_user.login(Request(), "testPassword")}
with client as request: with client as request:
@ -661,7 +660,6 @@ def test_tu_proposal_vote(client, proposal):
# Check that the proposal record got updated. # Check that the proposal record got updated.
assert voteinfo.Yes == yes + 1 assert voteinfo.Yes == yes + 1
assert voteinfo.ActiveTUs == active_tus + 1
# Check that the new TUVote exists. # Check that the new TUVote exists.
vote = db.query(TUVote, TUVote.VoteInfo == voteinfo, vote = db.query(TUVote, TUVote.VoteInfo == voteinfo,