From a08681ba2391b955cc39a8f62dbddcc153ea6cca Mon Sep 17 00:00:00 2001
From: moson-mo <mo-son@mailbox.org>
Date: Fri, 25 Nov 2022 12:24:04 +0100
Subject: [PATCH] fix: Add "Show more..." link for "Required by"

Fix glitch on the package page:
"Show more..." not displayed for the "Required by" list

Fix test case:
Function name does not start with "test" hence it was never executed during test runs

Issue report: #363

Signed-off-by: moson-mo <mo-son@mailbox.org>
---
 templates/partials/packages/package_metadata.html | 10 ++++++----
 test/test_packages_routes.py                      |  4 ++--
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/templates/partials/packages/package_metadata.html b/templates/partials/packages/package_metadata.html
index 123b994d..50d38b48 100644
--- a/templates/partials/packages/package_metadata.html
+++ b/templates/partials/packages/package_metadata.html
@@ -62,10 +62,12 @@
                 <em>{{ dep | dep_extra }}</em>
             </li>
         {% endfor %}
-        {% if not all_reqs and (required_by | length) > max_listing %}
-            <a href="/packages/{{ name }}?{{ q | extend_query(['all_reqs', '1']) | urlencode }}#pkgreqs">
-                {{ "Show %d more" | tr | format(reqs_count - (required_by | length)) }}...
-            </a>
+        {% if not all_reqs and reqs_count > max_listing %}
+            <li>
+                <a href="/packages/{{ package.Name }}?{{ q | extend_query(['all_reqs', '1']) | urlencode }}#pkgreqs">
+                    {{ "Show %d more" | tr | format(reqs_count - (required_by | length)) }}...
+                </a>
+            </li>
         {% endif %}
     </ul>
 </div>
diff --git a/test/test_packages_routes.py b/test/test_packages_routes.py
index 0da6cfab..c8986b9c 100644
--- a/test/test_packages_routes.py
+++ b/test/test_packages_routes.py
@@ -352,7 +352,7 @@ def test_package_split_description(client: TestClient, user: User):
     assert row.text == pkg_b.Description
 
 
-def paged_depends_required(client: TestClient, package: Package):
+def test_paged_depends_required(client: TestClient, package: Package):
     maint = package.PackageBase.Maintainer
     new_pkgs = []
 
@@ -360,7 +360,7 @@ def paged_depends_required(client: TestClient, package: Package):
         # Create 25 new packages that'll be used to depend on our package.
         for i in range(26):
             base = db.create(PackageBase, Name=f"new_pkg{i}", Maintainer=maint)
-            new_pkgs.append(db.create(Package, Name=base.Name))
+            new_pkgs.append(db.create(Package, Name=base.Name, PackageBase=base))
 
         # Create 25 deps.
         for i in range(25):