mirror of
https://gitlab.archlinux.org/archlinux/aurweb.git
synced 2025-02-03 10:43:03 +01:00
[FastAPI] Refactor db modifications
For SQLAlchemy to automatically understand updates from the external world, it must use an `autocommit=True` in its session. This change breaks how we were using commit previously, as `autocommit=True` causes SQLAlchemy to commit when a SessionTransaction context hits __exit__. So, a refactoring was required of our tests: All usage of any `db.{create,delete}` must be called **within** a SessionTransaction context, created via new `db.begin()`. From this point forward, we're going to require: ``` with db.begin(): db.create(...) db.delete(...) db.session.delete(object) ``` With this, we now get external DB modifications automatically without reloading or restarting the FastAPI server, which we absolutely need for production. Signed-off-by: Kevin Morris <kevr@0cost.org>
This commit is contained in:
parent
b52059d437
commit
a5943bf2ad
37 changed files with 998 additions and 902 deletions
|
@ -2,7 +2,7 @@ import pytest
|
|||
|
||||
from sqlalchemy.exc import IntegrityError
|
||||
|
||||
from aurweb.db import create
|
||||
from aurweb import db
|
||||
from aurweb.models.term import Term
|
||||
from aurweb.testing import setup_test_db
|
||||
|
||||
|
@ -18,8 +18,9 @@ def setup():
|
|||
|
||||
|
||||
def test_term_creation():
|
||||
term = create(Term, Description="Term description",
|
||||
URL="https://fake_url.io")
|
||||
with db.begin():
|
||||
term = db.create(Term, Description="Term description",
|
||||
URL="https://fake_url.io")
|
||||
assert bool(term.ID)
|
||||
assert term.Description == "Term description"
|
||||
assert term.URL == "https://fake_url.io"
|
||||
|
@ -27,14 +28,14 @@ def test_term_creation():
|
|||
|
||||
|
||||
def test_term_null_description_raises_exception():
|
||||
from aurweb.db import session
|
||||
with pytest.raises(IntegrityError):
|
||||
create(Term, URL="https://fake_url.io")
|
||||
session.rollback()
|
||||
with db.begin():
|
||||
db.create(Term, URL="https://fake_url.io")
|
||||
db.rollback()
|
||||
|
||||
|
||||
def test_term_null_url_raises_exception():
|
||||
from aurweb.db import session
|
||||
with pytest.raises(IntegrityError):
|
||||
create(Term, Description="Term description")
|
||||
session.rollback()
|
||||
with db.begin():
|
||||
db.create(Term, Description="Term description")
|
||||
db.rollback()
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue