From ab2956eef79aed68e8da3c37b237950916f78c25 Mon Sep 17 00:00:00 2001
From: Kevin Morris <kevr@0cost.org>
Date: Thu, 18 Aug 2022 16:02:03 -0700
Subject: [PATCH] feat: add pytest unit of independent user unflagging

Signed-off-by: Kevin Morris <kevr@0cost.org>
---
 test/test_pkgbase_routes.py | 49 +++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/test/test_pkgbase_routes.py b/test/test_pkgbase_routes.py
index f6bcf5d7..8be08f83 100644
--- a/test/test_pkgbase_routes.py
+++ b/test/test_pkgbase_routes.py
@@ -1457,3 +1457,52 @@ def test_unauthorized_pkgbase_keywords(client: TestClient, package: Package):
         endp = f"/pkgbase/{pkgbase.Name}/keywords"
         response = request.post(endp, cookies=cookies)
     assert response.status_code == HTTPStatus.UNAUTHORIZED
+
+
+def test_independent_user_unflag(client: TestClient, user: User,
+                                 package: Package):
+    with db.begin():
+        flagger = db.create(User, Username="test_flagger",
+                            Email="test_flagger@example.com",
+                            Passwd="testPassword")
+
+    pkgbase = package.PackageBase
+    cookies = {"AURSID": flagger.login(Request(), "testPassword")}
+    with client as request:
+        endp = f"/pkgbase/{pkgbase.Name}/flag"
+        response = request.post(endp, data={
+            "comments": "This thing needs a flag!"
+        }, cookies=cookies, allow_redirects=True)
+    assert response.status_code == HTTPStatus.OK
+
+    # At this point, we've flagged it as `flagger`.
+    # Now, we should be able to view the "Unflag package" link on the package
+    # page when browsing as that `flagger` user.
+    with client as request:
+        endp = f"/pkgbase/{pkgbase.Name}"
+        response = request.get(endp, cookies=cookies, allow_redirects=True)
+    assert response.status_code == HTTPStatus.OK
+
+    # Assert that the "Unflag package" link appears in the DOM.
+    root = parse_root(response.text)
+    elems = root.xpath('//input[@name="do_UnFlag"]')
+    assert len(elems) == 1
+
+    # Now, unflag the package by "clicking" the "Unflag package" link.
+    with client as request:
+        endp = f"/pkgbase/{pkgbase.Name}/unflag"
+        response = request.post(endp, cookies=cookies, allow_redirects=True)
+    assert response.status_code == HTTPStatus.OK
+
+    # For the last time, let's check the GET response. The package should
+    # not show as flagged anymore, and thus the "Unflag package" link
+    # should be missing.
+    with client as request:
+        endp = f"/pkgbase/{pkgbase.Name}"
+        response = request.get(endp, cookies=cookies, allow_redirects=True)
+    assert response.status_code == HTTPStatus.OK
+
+    # Assert that the "Unflag package" link does not appear in the DOM.
+    root = parse_root(response.text)
+    elems = root.xpath('//input[@name="do_UnFlag"]')
+    assert len(elems) == 0