From d1a66a743e6ca45ea13874015bcdcaaa1e2e1abe Mon Sep 17 00:00:00 2001 From: Jelle van der Waa Date: Fri, 9 Aug 2024 13:01:54 +0200 Subject: [PATCH] perf(aurweb/pkgbase): use exists() to avoid fetching a row The previous approach fetched the matching row, by using `exists()` SQLAlchemy changes the query to a `SELECT 1`. --- aurweb/pkgbase/util.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/aurweb/pkgbase/util.py b/aurweb/pkgbase/util.py index f33bbb49..7784638c 100644 --- a/aurweb/pkgbase/util.py +++ b/aurweb/pkgbase/util.py @@ -73,8 +73,10 @@ def make_context( context["out_of_date"] = bool(pkgbase.OutOfDateTS) if is_authenticated: - context["voted"] = request.user.package_votes.filter( - PackageVote.PackageBaseID == pkgbase.ID + context["voted"] = db.query( + request.user.package_votes.filter( + PackageVote.PackageBaseID == pkgbase.ID + ).exists() ).scalar() else: context["voted"] = False