From de7e3ab607b7dd75074a548f0980e8197ea4dadf Mon Sep 17 00:00:00 2001 From: Kevin Morris Date: Mon, 6 Dec 2021 22:35:22 -0800 Subject: [PATCH] fix(logging): restore aurweb logger; null out root logger After actually digging into how the logger does things, since the root logger is required and we have specific level-changing loggers for our components, we must no-op the root logger to avoid it duplicating logs from the others. Signed-off-by: Kevin Morris --- aurweb/logging.py | 1 + logging.conf | 19 +++++++++++++------ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/aurweb/logging.py b/aurweb/logging.py index 5c4a7b6a..b205a296 100644 --- a/aurweb/logging.py +++ b/aurweb/logging.py @@ -8,6 +8,7 @@ aurwebdir = aurweb.config.get("options", "aurwebdir") config_path = os.path.join(aurwebdir, "logging.conf") logging.config.fileConfig(config_path, disable_existing_loggers=False) +logging.getLogger("root").addHandler(logging.NullHandler()) def get_logger(name: str) -> logging.Logger: diff --git a/logging.conf b/logging.conf index deb79cf5..7dfd30f0 100644 --- a/logging.conf +++ b/logging.conf @@ -1,5 +1,5 @@ [loggers] -keys=root,uvicorn,hypercorn,alembic +keys=root,aurweb,uvicorn,hypercorn,alembic [handlers] keys=simpleHandler,detailedHandler @@ -9,17 +9,24 @@ keys=simpleFormatter,detailedFormatter [logger_root] level=INFO -handlers=detailedHandler -propogate=1 +; We add NullHandler programmatically. +handlers= +propogate=0 + +[logger_aurweb] +level=INFO +handlers=simpleHandler +qualname=aurweb +propagate=1 [logger_uvicorn] -level=DEBUG +level=INFO handlers=simpleHandler qualname=uvicorn propagate=0 [logger_hypercorn] -level=DEBUG +level=INFO handlers=simpleHandler qualname=hypercorn propagate=0 @@ -32,7 +39,7 @@ propagate=0 [handler_simpleHandler] class=StreamHandler -level=INFO +level=DEBUG formatter=simpleFormatter args=(sys.stdout,)