external/aurweb
0
0
Fork 0
mirror of https://gitlab.archlinux.org/archlinux/aurweb.git synced 2025-02-03 10:43:03 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

test_db: remove use of mkdtemp and os.removedirs

Browse source 
Signed-off-by: Kevin Morris <kevr@0cost.org>
This commit is contained in:
Kevin Morris 2021-05-16 06:26:38 -07:00
parent 1d5827007f
commit e0eb6b0e76
1 changed files with 22 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
test/test_db.py
View file

@ -57,10 +57,8 @@ def test_sqlalchemy_mysql_url():
def make_temp_config(backend): def make_temp_config(backend):
if not os.path.isdir("/tmp"): tmpdir = tempfile.TemporaryDirectory()
os.mkdir("/tmp") tmp = os.path.join(tmpdir.name, "config.tmp")
tmpdir = tempfile.mkdtemp()
tmp = os.path.join(tmpdir, "config.tmp")
with open("conf/config") as f: with open("conf/config") as f:
config = re.sub(r'backend = sqlite', f'backend = {backend}', f.read()) config = re.sub(r'backend = sqlite', f'backend = {backend}', f.read())
with open(tmp, "w") as o: with open(tmp, "w") as o:
@ -69,16 +67,14 @@ def make_temp_config(backend):
def test_sqlalchemy_unknown_backend(): def test_sqlalchemy_unknown_backend():
tmpdir, tmp = make_temp_config("blah") tmpctx, tmp = make_temp_config("blah")
with mock.patch.dict(os.environ, {"AUR_CONFIG": tmp}): with tmpctx:
with mock.patch.dict(os.environ, {"AUR_CONFIG": tmp}):
aurweb.config.rehash()
with pytest.raises(ValueError):
db.get_sqlalchemy_url()
aurweb.config.rehash() aurweb.config.rehash()
with pytest.raises(ValueError):
db.get_sqlalchemy_url()
aurweb.config.rehash()
os.remove(tmp)
os.removedirs(tmpdir)
def test_db_connects_without_fail(): def test_db_connects_without_fail():
@ -97,32 +93,28 @@ def test_connection_class_without_fail():
def test_connection_class_unsupported_backend(): def test_connection_class_unsupported_backend():
tmpdir, tmp = make_temp_config("blah") tmpctx, tmp = make_temp_config("blah")
with mock.patch.dict(os.environ, {"AUR_CONFIG": tmp}): with tmpctx:
with mock.patch.dict(os.environ, {"AUR_CONFIG": tmp}):
aurweb.config.rehash()
with pytest.raises(ValueError):
db.Connection()
aurweb.config.rehash() aurweb.config.rehash()
with pytest.raises(ValueError):
db.Connection()
aurweb.config.rehash()
os.remove(tmp)
os.removedirs(tmpdir)
@mock.patch("mysql.connector.connect", mock.MagicMock(return_value=True)) @mock.patch("mysql.connector.connect", mock.MagicMock(return_value=True))
@mock.patch.object(mysql.connector, "paramstyle", "qmark") @mock.patch.object(mysql.connector, "paramstyle", "qmark")
def test_connection_mysql(): def test_connection_mysql():
tmpdir, tmp = make_temp_config("mysql") tmpctx, tmp = make_temp_config("mysql")
with mock.patch.dict(os.environ, { with tmpctx:
"AUR_CONFIG": tmp, with mock.patch.dict(os.environ, {
"AUR_CONFIG_DEFAULTS": "conf/config.defaults" "AUR_CONFIG": tmp,
}): "AUR_CONFIG_DEFAULTS": "conf/config.defaults"
}):
aurweb.config.rehash()
db.Connection()
aurweb.config.rehash() aurweb.config.rehash()
db.Connection()
aurweb.config.rehash()
os.remove(tmp)
os.removedirs(tmpdir)
@mock.patch("sqlite3.connect", mock.MagicMock(return_value=DBConnection())) @mock.patch("sqlite3.connect", mock.MagicMock(return_value=DBConnection()))