external/aurweb
0
0
Fork 0
mirror of https://gitlab.archlinux.org/archlinux/aurweb.git synced 2025-02-03 10:43:03 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix strict standards warnings in "web/html/pkgsubmit.php".

Browse source 
end() expects a reference but we pass a function return value here.
Using list() is a bit hacky as well as it expects a 0-based array
whereas unpack() returns a 1-based array - thus we use "list(, $foo)".

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
This commit is contained in:
Lukas Fleischer 2011-03-30 12:27:25 +02:00
parent 47faf88f14
commit e4130fcca6
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
web/html/pkgsubmit.php
View file

@ -30,7 +30,7 @@ if ($_COOKIE["AURSID"]):
if (!$error) { if (!$error) {
$fh = fopen($_FILES['pfile']['tmp_name'], 'rb'); $fh = fopen($_FILES['pfile']['tmp_name'], 'rb');
fseek($fh, 0, SEEK_SET); fseek($fh, 0, SEEK_SET);
$magic = end(unpack('v', fread($fh, 2))); list(, $magic) = unpack('v', fread($fh, 2));
if ($magic != 0x8b1f) { if ($magic != 0x8b1f) {
$error = __("Error - unsupported file format (please submit gzip'ed tarballs generated by makepkg(8) only)."); $error = __("Error - unsupported file format (please submit gzip'ed tarballs generated by makepkg(8) only).");
@ -40,7 +40,7 @@ if ($_COOKIE["AURSID"]):
# Check uncompressed file size (ZIP bomb protection) # Check uncompressed file size (ZIP bomb protection)
if (!$error && $MAX_FILESIZE_UNCOMPRESSED) { if (!$error && $MAX_FILESIZE_UNCOMPRESSED) {
fseek($fh, -4, SEEK_END); fseek($fh, -4, SEEK_END);
$filesize_uncompressed = end(unpack('V', fread($fh, 4))); list(, $filesize_uncompressed) = unpack('V', fread($fh, 4));
if ($filesize_uncompressed > $MAX_FILESIZE_UNCOMPRESSED) { if ($filesize_uncompressed > $MAX_FILESIZE_UNCOMPRESSED) {
$error = __("Error - uncompressed file size too large."); $error = __("Error - uncompressed file size too large.");