external/aurweb
0
0
Fork 0
mirror of https://gitlab.archlinux.org/archlinux/aurweb.git synced 2025-02-03 10:43:03 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Display warning when flagging VCS packages

Browse source 
VCS packages should not be flagged out-of-date when the package version
does not match the most recent commit.

Implements FS#62733.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
This commit is contained in:
Lukas Fleischer 2019-05-25 12:48:58 -04:00
parent 5a66a381fb
commit fc9c519852
3 changed files with 34 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
web/html/css/aurweb.css
View file

@ -195,3 +195,7 @@ label.confirmation,
.comments .more { .comments .more {
font-weight: normal; font-weight: normal;
} }
.error {
color: red;
}

9
web/html/pkgflag.php
View file

@ -50,6 +50,15 @@ if (has_credential(CRED_PKGBASE_FLAG)): ?>
<li><?= htmlspecialchars($pkgname) ?></li> <li><?= htmlspecialchars($pkgname) ?></li>
<?php endforeach; ?> <?php endforeach; ?>
</ul> </ul>
<?php if (pkgbase_is_vcs($base_id)): ?>
<p class="error">
This seems to be a VCS package. Please do <strong>not</strong>
flag it out-of-date if the package version in the AUR does not
match the most recent commit. Flagging this package should only
be done if the sources moved or changes in the PKGBUILD are
required because of recent upstream changes.
</p>
<?php endif; ?>
<p> <p>
<?= __('Please do %snot%s use this form to report bugs. Use the package comments instead.', <?= __('Please do %snot%s use this form to report bugs. Use the package comments instead.',
'<strong>', '</strong>'); ?> '<strong>', '</strong>'); ?>

21
web/lib/pkgbasefuncs.inc.php
View file

@ -367,6 +367,27 @@ function pkgbase_get_pkgnames($base_id) {
return $result->fetchAll(PDO::FETCH_COLUMN, 0); return $result->fetchAll(PDO::FETCH_COLUMN, 0);
} }
/**
* Determine whether a package base is (or contains a) VCS package
*
* @param int $base_id The ID of the package base
*
* @return bool True if the package base is/contains a VCS package
*/
function pkgbase_is_vcs($base_id) {
$suffixes = array("-cvs", "-svn", "-git", "-hg", "-bzr", "-darcs");
$haystack = pkgbase_get_pkgnames($base_id);
array_push($haystack, pkgbase_name_from_id($base_id));
foreach ($haystack as $pkgname) {
foreach ($suffixes as $suffix) {
if (substr_compare($pkgname, $suffix, -strlen($suffix)) === 0) {
return true;
}
}
}
return false;
}
/** /**
* Delete all packages belonging to a package base * Delete all packages belonging to a package base
* *