Commit graph

1820 commits

Author SHA1 Message Date
Marcel Korpel
73364ad724 Correctly encode ampersand in query string within HTML attribute
Signed-off-by: Marcel Korpel <marcel.korpel@gmail.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2016-01-31 20:03:49 +01:00
Marcel Korpel
6b766b8e77 Shorten maxlength of email input fields to 254 characters
After 24734d0 (Shorten Email column to 254 characters, 2015-11-12) the
maximum length of the input fields should be shortened, too.

Signed-off-by: Marcel Korpel <marcel.korpel@gmail.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2016-01-30 11:15:17 +01:00
Lukas Fleischer
700df4f32f Include parentheses in translatable string
This string is easier to understand with the extra parentheses.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2016-01-28 23:00:08 +01:00
Marcel Korpel
2121982862 Rename constructors to __construct
In PHP 7, constructor methods that have the same name as the class
they are defined in are deprecated. Use __construct instead.
http://php.net/manual/en/migration70.deprecated.php

Signed-off-by: Marcel Korpel <marcel.korpel@gmail.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2016-01-28 22:55:32 +01:00
Mark Weiman
b3a6809bad Fix duplicate ids from pinned comments
Fixed duplicate ids caused from pinned comments introduced in 7d4c0c9
(Implement capability to pin comments above others, 2015-12-12).

Signed-off-by: Mark Weiman <mark.weiman@markzz.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2016-01-24 21:34:54 +01:00
Marcel Korpel
bd85441cf6 Add comment undeletion functionality
Only Developers and Trusted Users can undelete comments.

Signed-off-by: Marcel Korpel <marcel.korpel@gmail.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2016-01-23 11:50:03 +01:00
Mark Weiman
e9fe1a9eb1 Add link to flag OOD comment
Implements: FS#46546

Signed-off-by: Mark Weiman <mark.weiman@markzz.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-15 17:46:18 +01:00
Lukas Fleischer
4653945226 Hide names of deleted accounts in comment headings
When the account of a user who edited/deleted a comment is removed, drop
occurrences of his user name in comment headings instead of replacing
the user name with "None".

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-13 21:20:39 +01:00
Lukas Fleischer
51407d4a29 Store current date and time when deleting comments
Instead of modifying EditedTS when a comment is deleted, use a separate
field DelTS. Use this field to determine whether a comment has been
deleted, instead of checking DelUsersID which might be unset when the
corresponding user is deleted.

Fixes FS#47362.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-13 21:19:31 +01:00
Lukas Fleischer
9abd44671d Add a "more" link to the recent updates box
Implements FS#46924.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-13 18:28:06 +01:00
Lukas Fleischer
9c98523494 Replace new package icon
Use a flat icon from the Open Iconic collection to mark new packages.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-13 10:22:59 +01:00
Lukas Fleischer
a35dc4022a Replace RSS feed icon
Use a flat icon from the Open Iconic collection for the RSS feed.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-13 10:22:59 +01:00
Lukas Fleischer
256a343b18 Remove old logos
Remove some very old and outdated logos. Update the RSS feed to use the
new logo.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-13 10:22:59 +01:00
Lukas Fleischer
ff798420b5 Add the Open Iconic license
The new SVG icons used in aurweb are taken from the Open Iconic project.
Add their license to our source tree.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-13 10:22:59 +01:00
Lukas Fleischer
1f179c9fbc aurjson: Do not search by ID when argument is numeric
When performing info or multiinfo queries, one can currently either pass
package names or package IDs as parameters. As a consequence, it is
impossible to search for packages with a numeric package name because
numeric arguments are always treated as IDs. Since package IDs are not
public anymore these days, simply remove the possibility to search by ID
in revision 5 of the RPC interface.

Fixes FS#47324.

Suggested-by: Dave Reisner <dreisner@archlinux.org>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-13 10:22:59 +01:00
Lukas Fleischer
e45609cf66 notify: Do not pass notification texts via pipes
Directly retrieve comments from the database instead of additionally
passing them via stdin.

Fixes FS#46742.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-13 10:22:58 +01:00
Lukas Fleischer
5931d5ceec Save comment when closing requests
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-13 10:22:58 +01:00
Lukas Fleischer
c085be8c0d Only show "last edited" to logged in users
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-12 21:59:35 +01:00
Mark Weiman
7d4c0c9ffa Implement capability to pin comments above others
Adds capability to pin comments before others.

Implements FS#10863.

Signed-off-by: Mark Weiman <mark.weiman@markzz.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-12 15:09:47 +01:00
Mark Weiman
3088fd0f38 Remove reassignment of base_id in pkg_comments.php
Removes reassignment of $base_id in web/template/pkg_comments.php as it is
assigned in both pkgbase_display_details() and pkg_display_details().

Signed-off-by: Mark Weiman <mark.weiman@markzz.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-12-12 15:09:44 +01:00
Lukas Fleischer
a9048bb07f Dedupe translatable strings
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-11-26 17:26:13 +01:00
Eli Schwartz
ecb746971c Change "File Request" to "Submit Request"
Apparently the reference to "files" can be confusing.

Fixes FS#47167.

Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-11-25 08:06:50 +01:00
Lukas Fleischer
a114476e81 Make the notification script configurable
Add a configuration option to set the path of the notification script.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-11-14 09:27:35 +01:00
Lukas Fleischer
0c599b39b0 Remove redundant code
This code is no longer needed since 9746a65 (Port notification routines
to Python, 2015-06-27).

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-11-12 11:47:20 +01:00
Lukas Fleischer
81bfb367c8 footer: Close short open tag
Fixes a regression introduced in fd6ba76 (Make copyright notice
translatable, 2015-10-17).

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-31 10:14:49 +01:00
Lukas Fleischer
d52b2f50b9 Support long email addresses
According to RFC 3696 (and the associated errata), an email address can
be up to 256 characters long. Change the database field and the length
limit on all input fields accordingly.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-25 10:57:46 +01:00
Lukas Fleischer
f9ac67f691 Fix user name length limit on the account edit form
Change the maxlength attribute of the user name input field such that it
corresponds to the username_max_len option.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-25 10:46:11 +01:00
Lukas Fleischer
66d12f0c37 Highlight broken dependencies
If a dependency neither exists in the official repositories nor in the
AUR, make it appear bold red.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-24 18:59:04 +02:00
Lukas Fleischer
8dcf225f63 Hide optdepend description if not available
Remove the "(unknown)" suffix that used to be shown for optional
dependencies without a description.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-24 18:50:44 +02:00
Lukas Fleischer
b30135111a Include trivial AUR providers in pkg_providers()
When obtaining provisions using pkg_providers(), we already include
virtual providers from the official repositories, virtual providers from
the AUR and trivial providers (i.e. packages having the given name) from
the official repositories. Include trivial providers from the AUR as
well.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-24 18:33:00 +02:00
Lukas Fleischer
5d119c02ea Always retrieve dependency providers
Since commit 16765d5 (Track providers in the official repositories,
2015-10-21), we know all packages and virtual provisions from the
official repositories. Always obtain and display all providers from both
the official repositories and the AUR.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-24 18:22:25 +02:00
Lukas Fleischer
b74a87abfc Fix spacing of versioned dependencies
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-24 18:13:48 +02:00
Lukas Fleischer
d7cba28ad2 Disable mass unflagging
This currently does not work. Disable it until we have proper support
for flagging multiple packages on the flag page.

Fixes FS#46780.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-24 18:04:26 +02:00
Lukas Fleischer
a2cbc7f646 aurjson: Allow underscores in JSONP callback names
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-24 18:03:19 +02:00
Lukas Fleischer
ca954fe95a Do not redirect when showing errors during flagging
Fixes FS#46545.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-22 07:17:38 +02:00
Lukas Fleischer
9c70e10aeb Check comment length in the backend
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-21 22:32:29 +02:00
Lukas Fleischer
16765d5532 Track providers in the official repositories
Maintain a list of virtual provisions of packages from the official
binary package repositories. The list can be updated using the aurblup
script, e.g. via a cronjob.

This allows for adding proper links to package dependencies: If an AUR
package depends on a package from the official repositories (or on a
name provided by a package from the official repositories), add a link
to the corresponding archweb package details page. If an AUR package
depends on another AUR package (or on a name provided by another AUR
package), add a link to the corresponding aurweb package details page.
Otherwise, just display the name and do not add a link at all.

Fixes FS#46549.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-21 22:05:42 +02:00
Lukas Fleischer
4411a55ec9 Send notifications when changing co-maintainership
Implements FS#45590.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-17 17:33:45 +02:00
Lukas Fleischer
2f6471b0b1 Refactor pkgbase_set_comaintainers()
This makes the code slightly more efficient and allows for easily
determining the users that were added/removed to the co-maintainer list.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-17 17:33:07 +02:00
Lukas Fleischer
fd6ba76431 Make copyright notice translatable
Fixes FS#46747.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-17 17:31:48 +02:00
Lukas Fleischer
1f6237ffa7 aurjson: Rename the search_by parameter to "by"
This parameter is only supported by the search command. We do not need
to repeat ourselves.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-09 17:35:51 +02:00
Lukas Fleischer
9d8345d4e0 rpc.php: Display generated documentation
Instead of hardcoding the RPC interface documentation in rpc.php,
include the HTML code of the documentation page generated by AsciiDoc.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-04 11:40:38 +02:00
Lukas Fleischer
3c06716c72 aurjson: Merge info and multiinfo commands
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-04 11:40:38 +02:00
Lukas Fleischer
261c7f74dd aurjson: Add "maintainer" search type
Deprecate the msearch command and add a new search type to the search
command.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-04 11:40:37 +02:00
Lukas Fleischer
eb3b0d537d Release 4.1.1
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-03 12:12:03 +02:00
Lukas Fleischer
4fe513d838 Do not redirect to details page after deletion
When deleting a package base from the package base deletion form, do not
try to redirect to the package base details page afterwards. Instead,
jump to the package overview.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-03 11:57:44 +02:00
Lukas Fleischer
90e96e3728 Redirect to details pages after performing actions
After performing a package base action on a separate page, return to the
corresponding package base details page.

Partly fixes FS#46545.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-03 11:28:04 +02:00
Lukas Fleischer
d0f8b285e4 Fix a PHP "Undefined index" notice
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-03 11:15:53 +02:00
Lukas Fleischer
d18a9638c6 Fix dependency sorting
Fixes a regression introduced in 9d2d8f1 (Honor virtual provisions in
package requirements, 2015-09-17).

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-03 11:12:18 +02:00
Lukas Fleischer
f5b4f7e996 Fix parameter processing in parse_multiinfo_args()
Fixes a regression introduced in 94aeead (aurjson: Pass http_data array
to all functions, 2015-06-28).

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2015-10-03 11:07:39 +02:00