38dc2bb99d
Some of these tests were written before some of our convenient
tooling existed. Additionally, some of the tests were not
cooperating with PEP-8 guidelines or isorted.
This commit does the following:
- Replaces all calls to make_(user|session) with
aurweb.db.create(Model, ...).
- Replace calls to session.add(...) + session.commit() with
aurweb.db.create.
- Removes the majority of calls to (session|aurweb.db).delete(...).
- Replaces session.query calls with aurweb.db.query.
- Initializes all mutable globals in pytest fixture setup().
- Makes mutable global declarations more concise:
`var1, var2 = None, None` -> `var1 = var2 = None`
- Defines a warning exclusion for test/test_ssh_pub_key.py.
- Removes the aurweb.testing.models module.
- Removes some useless pytest.fixture yielding.
As of this commit, developers should use the following guidelines
when writing tests:
- Always use aurweb.db.(create|delete|query) for database
operations, where possible.
- Always define mutable globals in the style: `var1 = var2 = None`.
- `yield` the most dependent model in pytest setup fixture **iff**
you must delete records after test runs to maintain database
integrity. Example: test/test_account_type.py.
This all makes the test code look and behave much cleaner.
Previously, aurweb.testing.setup_test_db was buggy and leaving
objects around in SQLAlchemy's IdentityMap.
Signed-off-by: Kevin Morris <kevr@0cost.org>
|
||
|---|---|---|
| .tx | ||
| aurweb | ||
| conf | ||
| doc | ||
| migrations | ||
| po | ||
| schema | ||
| templates | ||
| test | ||
| upgrading | ||
| util | ||
| web | ||
| .coveragerc | ||
| .editorconfig | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .mailmap | ||
| .pre-commit-config.yaml | ||
| alembic.ini | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| COPYING | ||
| Dockerfile | ||
| INSTALL | ||
| README.md | ||
| setup.cfg | ||
| setup.py | ||
| TESTING | ||
aurweb
aurweb is a hosting platform for the Arch User Repository (AUR), a collection
of packaging scripts that are created and submitted by the Arch Linux
community. The scripts contained in the repository can be built using makepkg
and installed using the Arch Linux package manager pacman.
The aurweb project includes
- A web interface to search for packaging scripts and display package details.
- An SSH/Git interface to submit and update packages and package meta data.
- Community features such as comments, votes, package flagging and requests.
- Editing/deletion of packages and accounts by Trusted Users and Developers.
- Area for Trusted Users to post AUR-related proposals and vote on them.
Directory Layout
aurweb: aurweb Python modules, Git interface and maintenance scriptsconf: configuration and configuration templatesstatic: static resource filestemplates: jinja2 template collectiondoc: project documentationpo: translation files for strings in the aurweb interfaceschema: schema for the SQL databasetest: test suite and test casesupgrading: instructions for upgrading setups from one release to anotherweb: PHP-based web interface for the AUR
Links
-
The repository is hosted at git://git.archlinux.org/aurweb.git -- see doc/CodingGuidelines for information on the patch submission process.
-
Bugs can (and should) be submitted to the aurweb bug tracker: https://bugs.archlinux.org/index.php?project=2
-
Questions, comments, and patches related to aurweb can be sent to the AUR development mailing list: aur-dev@archlinux.org -- mailing list archives: https://mailman.archlinux.org/mailman/listinfo/aur-dev
Translations
Translations are welcome via our Transifex project at
https://www.transifex.com/lfleischer/aurweb; see doc/i18n.txt for details.
Testing
See test/README.md for details on dependencies and testing.