aurweb/test
Kevin Morris 4b0cb0721d
fix(conftest): use synchronization locks for setup_database
We were running into data race issues where the `fn.is_file()`
check would occur twice before writing the file in the `else`
clause. For this reason, a new aurweb.lock.Lock class has been
added which doubles as a thread and process lock. We can use
this elsewhere in the future, but we are also able to use it
to solve this kind of data race issue.

That being said, we still need the lock file state to tell us
when the first caller acquired the lock.

Signed-off-by: Kevin Morris <kevr@0cost.org>
2021-11-28 19:55:11 -08:00
..
scripts Makefile: run pytest units 2021-06-05 19:49:19 -07:00
__init__.py aurweb: Globalize a Translator instance, add more utility 2021-06-05 19:49:42 -07:00
conftest.py fix(conftest): use synchronization locks for setup_database 2021-11-28 19:55:11 -08:00
Makefile change: set -v for sh tests 2021-11-22 10:22:32 -08:00
README.md fix(FastAPI): Improve sqlite testing speed 2021-10-03 15:59:52 -07:00
setup.sh fix(sharness): fix AUR_CONFIG generation for mkpkglists test 2021-11-10 07:39:23 -08:00
sharness.sh sharness: do not use spaces in trash directory 2021-07-27 16:24:34 -07:00
t1100-git-auth.t Makefile: run pytest units 2021-06-05 19:49:19 -07:00
t1200-git-serve.t Makefile: run pytest units 2021-06-05 19:49:19 -07:00
t1300-git-update.t Makefile: run pytest units 2021-06-05 19:49:19 -07:00
t2600-rendercomment.t Makefile: run pytest units 2021-06-05 19:49:19 -07:00
test_accepted_term.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_account_type.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_accounts_routes.py change(fastapi): decouple error logic from process_account_form 2021-11-17 05:58:08 -08:00
test_api_rate_limit.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_asgi.py change(fastapi): remove sqlite support 2021-11-17 01:34:59 -08:00
test_aurblup.py change(aurblup): converted to use aurweb.db ORM 2021-11-28 19:55:08 -08:00
test_auth.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_auth_routes.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_ban.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_cache.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_captcha.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_config.py feat(aurweb-config): add unset action and simplify 2021-11-27 22:34:15 -08:00
test_db.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_defaults.py feat(FastAPI): added /requests (get) route 2021-10-02 22:43:48 -07:00
test_dependency_type.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_exceptions.py Sanitize and modernize pytests 2021-06-05 20:11:17 -07:00
test_filelock.py fix(conftest): use synchronization locks for setup_database 2021-11-28 19:55:11 -08:00
test_group.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_homepage.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_html.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_initdb.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_l10n.py jinja2: add 'tn' filter, a numerical translation 2021-08-30 18:49:01 -07:00
test_license.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_logging.py fix(fastapi): centralize logging initialization 2021-10-21 10:40:52 -07:00
test_mkpkglists.py change(mkpkglists): converted to use aurweb.db ORM 2021-11-28 19:55:08 -08:00
test_notify.py change(notify): converted to use aurweb.db ORM 2021-11-28 19:55:10 -08:00
test_official_provider.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package_base.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package_blacklist.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package_comaintainer.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package_comment.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package_dependency.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package_group.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package_keyword.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package_license.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package_notification.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package_relation.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package_request.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package_source.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_package_vote.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_packages_routes.py fix(fastapi): utilize auto_{orphan,deletion}_age 2021-11-18 21:27:03 -08:00
test_packages_util.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_pkgmaint.py change(pkgmaint): converted to use aurweb.db ORM 2021-11-28 19:55:10 -08:00
test_popupdate.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_ratelimit.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_redis.py FastAPI: add redis integration 2021-08-17 19:58:28 -07:00
test_relation_type.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_request_type.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_routes.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_rpc.py change(popupdate): converted to use aurweb.db ORM 2021-11-28 19:55:07 -08:00
test_rss.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_session.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_spawn.py feat: add test_spawn, an aurweb.spawn test 2021-11-20 15:47:25 -08:00
test_ssh_pub_key.py fix global test_ssh_pub_key E501 flake8 violation 2021-11-17 06:00:12 -08:00
test_templates.py feat(fastapi): add configurable commit hash display 2021-10-24 18:12:19 -07:00
test_term.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_time.py add aurweb.time module 2021-06-05 20:11:17 -07:00
test_trusted_user_routes.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_tu_vote.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_tu_voteinfo.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_tuvotereminder.py change(tuvotereminder): converted to use aurweb.db ORM 2021-11-28 19:55:09 -08:00
test_user.py change(aurweb): add parallel tests and improve aurweb.db 2021-11-17 01:34:59 -08:00
test_usermaint.py change(usermaint): converted to use aurweb.db ORM 2021-11-28 19:55:09 -08:00
test_util.py feat(FastAPI): added /requests (get) route 2021-10-02 22:43:48 -07:00

aurweb Test Collection

To run all tests, you may run make check under test/ (alternative targets: make pytest, make sh).

For more control, you may use the prove or pytest command, which receives a directory or a list of files to run, and produces a report.

Each test script is standalone, so you may run them individually. Some tests may receive command-line options to help debugging. See for example sharness's documentation for shell test scripts: https://github.com/chriscool/sharness/blob/master/README.git

Dependencies

For all the test to run, the following Arch packages should be installed:

  • pyalpm
  • python-alembic
  • python-bleach
  • python-markdown
  • python-pygit2
  • python-sqlalchemy
  • python-srcinfo
  • python-coverage
  • python-pytest
  • python-pytest-cov
  • python-pytest-asyncio
  • postfix
  • openssh

Optional (faster testing)

  • libeatmydata

Test Configuration

To perform any tests, we need to supply aurweb with a valid configuration. For development (and testing) purposes, an example conf/config.dev can be slightly modified.

Start off by copying config.dev to a new configuration.

$ cp -v conf/config.dev conf/config

First, we must tell aurweb where the root of our project lives by replacing YOUR_AUR_ROOT with the path to the aurweb repository.

$ sed -i "s;YOUR_AUR_ROOT;/path/to/aurweb;g" conf/config

Now, one must decide a database backend to use; see Test Database for details on configuring the different supported backends.

Test Database

Users may choose to configure one of several backends, including: mysql and sqlite. By default, conf/config.dev is configured for a the mysql backend using a test database named aurweb_test.

Users can initialize an empty MySQL database by performing the following:

$ cat conf/config
[database]
backend = mysql
name = aurweb_test
user = aur
password = aur
socket = /var/run/mysqld/mysqld.sock
...

# mysql -u root -e "CREATE USER 'aur'@'localhost' IDENTIFIED BY 'aur'"
# mysql -u root -e "CREATE DATABASE aurweb_test"
# mysql -u root -e "GRANT ALL ON aurweb_test.* TO 'aur'@'localhost'"
# mysql -u root -e "FLUSH ALL PRIVILEGES"

$ export AUR_CONFIG=conf/config
$ python3 -m aurweb.initdb

Or more lightweight with sqlite:

$ cat $AUR_CONFIG
[database]
backend = sqlite
name = aurweb.sqlite3
...

$ export AUR_CONFIG=conf/config
$ python3 -m aurweb.initdb

After initializing a fresh test database, users can continue on to Running Tests.

Running tests

Recommended method of running tests: make check.

Makefile test targets: sh, pytest.

Run tests from the project root.

$ cd /path/to/aurweb

Ensure you have the proper AUR_CONFIG exported:

$ export AUR_CONFIG=conf/config

To run sharness shell test suites (requires Arch Linux):

$ make -C test sh

To run pytest Python test suites:

$ make -C test pytest

Note: For SQLite tests, users may want to use eatmydata to improve speed:

$ eatmydata -- make -C test sh
$ eatmydata -- make -C test pytest

To produce coverage reports related to Python when running tests manually, use the following method:

$ coverage run --append /path/to/python/file.py

Note: Sharness test suites (shell) internally run coverage run.

After tests are run, one can produce coverage reports.

# Print out a CLI coverage report.
$ coverage report

# Produce an HTML-based coverage report.
$ coverage html

Writing Python tests (current)

Almost all of our pytest suites use the database in some way. There are a few particular testing utilities in aurweb that one should keep aware of to aid testing code:

  • aurweb.testing.setup_init_db(*tables)
    • Prepares test database tables to be cleared before a test is run. Be careful not to specify any tables we depend on for constant records, like AccountTypes, DependencyTypes, RelationTypes and RequestTypes.
  • aurweb.testing.requests.Request
    • A fake stripped down version of fastapi.Request that can be passed to any functions in our codebase which use fastapi.Request parameters.

Example code:

import pytest

from aurweb import db
from aurweb.models.user import User
from aurweb.testing import setup_test_db
from aurweb.testing.requests import Request


@pytest.fixture(autouse=True)
def setup():
    setup_test_db(User.__tablename__)

@pytest.fixture
def user():
    yield db.create(User, Passwd="testPassword", ...)

def test_user_login(user):
    assert isinstance(user, User) is True

    fake_request = Request()
    sid = user.login(fake_request, "testPassword")
    assert sid is not None

Writing Sharness tests (legacy)

Shell test scripts must follow the Test Anything Protocol specification: http://testanything.org/tap-specification.html

Python tests must be compatible with pytest and included in pytest test/ execution after setting up a configuration.

Tests must support being run from any directory. They may use $0 to determine their location. Python scripts should expect aurweb to be installed and importable without toying with os.path or PYTHONPATH.

Tests written in shell should use sharness. In general, new tests should be consistent with existing tests unless they have a good reason not to.

Debugging Sharness tests

By default, make -C test is quiet and does not print out verbose information about tests being run. If a test is failing, one can look into verbose details of sharness tests by executing them with the --verbose flag. Example: ./t1100_git_auth.t --verbose. This is particularly useful when tests happen to fail in a remote continuous integration environment, where the reader does not have complete access to the runner.