mirror of
https://gitlab.archlinux.org/archlinux/aurweb.git
synced 2025-02-03 10:43:03 +01:00
38dc2bb99d
Some of these tests were written before some of our convenient
tooling existed. Additionally, some of the tests were not
cooperating with PEP-8 guidelines or isorted.
This commit does the following:
- Replaces all calls to make_(user|session) with
aurweb.db.create(Model, ...).
- Replace calls to session.add(...) + session.commit() with
aurweb.db.create.
- Removes the majority of calls to (session|aurweb.db).delete(...).
- Replaces session.query calls with aurweb.db.query.
- Initializes all mutable globals in pytest fixture setup().
- Makes mutable global declarations more concise:
`var1, var2 = None, None` -> `var1 = var2 = None`
- Defines a warning exclusion for test/test_ssh_pub_key.py.
- Removes the aurweb.testing.models module.
- Removes some useless pytest.fixture yielding.
As of this commit, developers should use the following guidelines
when writing tests:
- Always use aurweb.db.(create|delete|query) for database
operations, where possible.
- Always define mutable globals in the style: `var1 = var2 = None`.
- `yield` the most dependent model in pytest setup fixture **iff**
you must delete records after test runs to maintain database
integrity. Example: test/test_account_type.py.
This all makes the test code look and behave much cleaner.
Previously, aurweb.testing.setup_test_db was buggy and leaving
objects around in SQLAlchemy's IdentityMap.
Signed-off-by: Kevin Morris <kevr@0cost.org>
108 lines
3 KiB
Python
108 lines
3 KiB
Python
import urllib.parse
|
|
|
|
from http import HTTPStatus
|
|
|
|
import pytest
|
|
|
|
from fastapi.testclient import TestClient
|
|
|
|
from aurweb.asgi import app
|
|
from aurweb.db import create, query
|
|
from aurweb.models.account_type import AccountType
|
|
from aurweb.models.user import User
|
|
from aurweb.testing import setup_test_db
|
|
from aurweb.testing.requests import Request
|
|
|
|
user = client = None
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def setup():
|
|
global user, client
|
|
|
|
setup_test_db("Users", "Sessions")
|
|
|
|
account_type = query(AccountType,
|
|
AccountType.AccountType == "User").first()
|
|
user = create(User, Username="test", Email="test@example.org",
|
|
RealName="Test User", Passwd="testPassword",
|
|
AccountType=account_type)
|
|
|
|
client = TestClient(app)
|
|
|
|
|
|
def test_index():
|
|
""" Test the index route at '/'. """
|
|
# Use `with` to trigger FastAPI app events.
|
|
with client as req:
|
|
response = req.get("/")
|
|
assert response.status_code == int(HTTPStatus.OK)
|
|
|
|
|
|
def test_favicon():
|
|
""" Test the favicon route at '/favicon.ico'. """
|
|
response1 = client.get("/static/images/favicon.ico")
|
|
response2 = client.get("/favicon.ico")
|
|
assert response1.status_code == int(HTTPStatus.OK)
|
|
assert response1.content == response2.content
|
|
|
|
|
|
def test_language():
|
|
""" Test the language post route as a guest user. """
|
|
post_data = {
|
|
"set_lang": "de",
|
|
"next": "/"
|
|
}
|
|
with client as req:
|
|
response = req.post("/language", data=post_data)
|
|
assert response.status_code == int(HTTPStatus.SEE_OTHER)
|
|
|
|
|
|
def test_language_invalid_next():
|
|
""" Test an invalid next route at '/language'. """
|
|
post_data = {
|
|
"set_lang": "de",
|
|
"next": "https://evil.net"
|
|
}
|
|
with client as req:
|
|
response = req.post("/language", data=post_data)
|
|
assert response.status_code == int(HTTPStatus.BAD_REQUEST)
|
|
|
|
|
|
def test_user_language():
|
|
""" Test the language post route as an authenticated user. """
|
|
post_data = {
|
|
"set_lang": "de",
|
|
"next": "/"
|
|
}
|
|
|
|
sid = user.login(Request(), "testPassword")
|
|
assert sid is not None
|
|
|
|
with client as req:
|
|
response = req.post("/language", data=post_data,
|
|
cookies={"AURSID": sid})
|
|
assert response.status_code == int(HTTPStatus.SEE_OTHER)
|
|
assert user.LangPreference == "de"
|
|
|
|
|
|
def test_language_query_params():
|
|
""" Test the language post route with query params. """
|
|
next = urllib.parse.quote_plus("/")
|
|
post_data = {
|
|
"set_lang": "de",
|
|
"next": "/",
|
|
"q": f"next={next}"
|
|
}
|
|
q = post_data.get("q")
|
|
with client as req:
|
|
response = req.post("/language", data=post_data)
|
|
assert response.headers.get("location") == f"/?{q}"
|
|
assert response.status_code == int(HTTPStatus.SEE_OTHER)
|
|
|
|
|
|
def test_error_messages():
|
|
response1 = client.get("/thisroutedoesnotexist")
|
|
response2 = client.get("/raisefivethree")
|
|
assert response1.status_code == int(HTTPStatus.NOT_FOUND)
|
|
assert response2.status_code == int(HTTPStatus.SERVICE_UNAVAILABLE)
|