mirror of
https://gitlab.archlinux.org/archlinux/aurweb.git
synced 2025-02-03 10:43:03 +01:00
a5943bf2ad
For SQLAlchemy to automatically understand updates from the
external world, it must use an `autocommit=True` in its session.
This change breaks how we were using commit previously, as
`autocommit=True` causes SQLAlchemy to commit when a
SessionTransaction context hits __exit__.
So, a refactoring was required of our tests: All usage of
any `db.{create,delete}` must be called **within** a
SessionTransaction context, created via new `db.begin()`.
From this point forward, we're going to require:
```
with db.begin():
db.create(...)
db.delete(...)
db.session.delete(object)
```
With this, we now get external DB modifications automatically
without reloading or restarting the FastAPI server, which we
absolutely need for production.
Signed-off-by: Kevin Morris <kevr@0cost.org>
36 lines
1 KiB
Python
36 lines
1 KiB
Python
import pytest
|
|
|
|
from sqlalchemy.exc import IntegrityError
|
|
|
|
from aurweb import db
|
|
from aurweb.models.package_base import PackageBase
|
|
from aurweb.models.package_blacklist import PackageBlacklist
|
|
from aurweb.models.user import User
|
|
from aurweb.testing import setup_test_db
|
|
|
|
user = pkgbase = None
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def setup():
|
|
global user, pkgbase
|
|
|
|
setup_test_db("PackageBlacklist", "PackageBases", "Users")
|
|
|
|
user = db.create(User, Username="test", Email="test@example.org",
|
|
RealName="Test User", Passwd="testPassword")
|
|
pkgbase = db.create(PackageBase, Name="test-package", Maintainer=user)
|
|
|
|
|
|
def test_package_blacklist_creation():
|
|
with db.begin():
|
|
package_blacklist = db.create(PackageBlacklist, Name="evil-package")
|
|
assert bool(package_blacklist.ID)
|
|
assert package_blacklist.Name == "evil-package"
|
|
|
|
|
|
def test_package_blacklist_null_name_raises_exception():
|
|
with pytest.raises(IntegrityError):
|
|
with db.begin():
|
|
db.create(PackageBlacklist)
|
|
db.rollback()
|