mirror of
https://gitlab.archlinux.org/archlinux/aurweb.git
synced 2025-02-03 10:43:03 +01:00
For SQLAlchemy to automatically understand updates from the external world, it must use an `autocommit=True` in its session. This change breaks how we were using commit previously, as `autocommit=True` causes SQLAlchemy to commit when a SessionTransaction context hits __exit__. So, a refactoring was required of our tests: All usage of any `db.{create,delete}` must be called **within** a SessionTransaction context, created via new `db.begin()`. From this point forward, we're going to require: ``` with db.begin(): db.create(...) db.delete(...) db.session.delete(object) ``` With this, we now get external DB modifications automatically without reloading or restarting the FastAPI server, which we absolutely need for production. Signed-off-by: Kevin Morris <kevr@0cost.org>
71 lines
2.3 KiB
Python
71 lines
2.3 KiB
Python
import pytest
|
|
|
|
from sqlalchemy.exc import IntegrityError
|
|
|
|
from aurweb.db import begin, create, query, rollback
|
|
from aurweb.models.account_type import AccountType
|
|
from aurweb.models.package_base import PackageBase
|
|
from aurweb.models.package_comment import PackageComment
|
|
from aurweb.models.user import User
|
|
from aurweb.testing import setup_test_db
|
|
|
|
user = pkgbase = None
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def setup():
|
|
setup_test_db("PackageBases", "PackageComments", "Users")
|
|
|
|
global user, pkgbase
|
|
|
|
account_type = query(AccountType,
|
|
AccountType.AccountType == "User").first()
|
|
with begin():
|
|
user = create(User, Username="test", Email="test@example.org",
|
|
RealName="Test User", Passwd="testPassword",
|
|
AccountType=account_type)
|
|
pkgbase = create(PackageBase, Name="test-package", Maintainer=user)
|
|
|
|
|
|
def test_package_comment_creation():
|
|
with begin():
|
|
package_comment = create(PackageComment,
|
|
PackageBase=pkgbase,
|
|
User=user,
|
|
Comments="Test comment.",
|
|
RenderedComment="Test rendered comment.")
|
|
assert bool(package_comment.ID)
|
|
|
|
|
|
def test_package_comment_null_package_base_raises_exception():
|
|
with pytest.raises(IntegrityError):
|
|
with begin():
|
|
create(PackageComment, User=user, Comments="Test comment.",
|
|
RenderedComment="Test rendered comment.")
|
|
rollback()
|
|
|
|
|
|
def test_package_comment_null_user_raises_exception():
|
|
with pytest.raises(IntegrityError):
|
|
with begin():
|
|
create(PackageComment, PackageBase=pkgbase,
|
|
Comments="Test comment.",
|
|
RenderedComment="Test rendered comment.")
|
|
rollback()
|
|
|
|
|
|
def test_package_comment_null_comments_raises_exception():
|
|
with pytest.raises(IntegrityError):
|
|
with begin():
|
|
create(PackageComment, PackageBase=pkgbase, User=user,
|
|
RenderedComment="Test rendered comment.")
|
|
rollback()
|
|
|
|
|
|
def test_package_comment_null_renderedcomment_defaults():
|
|
with begin():
|
|
record = create(PackageComment,
|
|
PackageBase=pkgbase,
|
|
User=user,
|
|
Comments="Test comment.")
|
|
assert record.RenderedComment == str()
|