mirror of
https://gitlab.archlinux.org/archlinux/aurweb.git
synced 2025-02-03 10:43:03 +01:00
fa43f6bc3e
This change utilizes pytest-xdist to perform a multiproc test
run and reworks aurweb.db's code. We no longer use a global
engine, session or Session, but we now use a memo of engines
and sessions as they are requested, based on the PYTEST_CURRENT_TEST
environment variable, which is available during testing.
Additionally, this change strips several SQLite components
out of the Python code-base.
SQLite is still compatible with PHP and sharness tests, but
not with our FastAPI implementation.
More changes:
------------
- Remove use of aurweb.db.session global in other code.
- Use new aurweb.db.name() dynamic db name function in env.py.
- Added 'addopts' to pytest.ini which utilizes multiprocessing.
- Highly recommended to leave this be or modify `-n auto` to
`-n {cpu_threads}` where cpu_threads is at least 2.
Signed-off-by: Kevin Morris <kevr@0cost.org>
117 lines
3.3 KiB
Python
117 lines
3.3 KiB
Python
from unittest import mock
|
|
|
|
import pytest
|
|
|
|
from redis.client import Pipeline
|
|
|
|
from aurweb import config, db, logging
|
|
from aurweb.models import ApiRateLimit
|
|
from aurweb.ratelimit import check_ratelimit
|
|
from aurweb.redis import redis_connection
|
|
from aurweb.testing.requests import Request
|
|
|
|
logger = logging.get_logger(__name__)
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def setup(db_test):
|
|
return
|
|
|
|
|
|
@pytest.fixture
|
|
def pipeline():
|
|
redis = redis_connection()
|
|
pipeline = redis.pipeline()
|
|
|
|
pipeline.delete("ratelimit-ws:127.0.0.1")
|
|
pipeline.delete("ratelimit:127.0.0.1")
|
|
pipeline.execute()
|
|
|
|
yield pipeline
|
|
|
|
|
|
config_getint = config.getint
|
|
|
|
|
|
def mock_config_getint(section: str, key: str):
|
|
if key == "request_limit":
|
|
return 4
|
|
elif key == "window_length":
|
|
return 100
|
|
return config_getint(section, key)
|
|
|
|
|
|
config_getboolean = config.getboolean
|
|
|
|
|
|
def mock_config_getboolean(return_value: int = 0):
|
|
def fn(section: str, key: str):
|
|
if section == "ratelimit" and key == "cache":
|
|
return return_value
|
|
return config_getboolean(section, key)
|
|
return fn
|
|
|
|
|
|
config_get = config.get
|
|
|
|
|
|
def mock_config_get(return_value: str = "none"):
|
|
def fn(section: str, key: str):
|
|
if section == "options" and key == "cache":
|
|
return return_value
|
|
return config_get(section, key)
|
|
return fn
|
|
|
|
|
|
@mock.patch("aurweb.config.getint", side_effect=mock_config_getint)
|
|
@mock.patch("aurweb.config.getboolean", side_effect=mock_config_getboolean(1))
|
|
@mock.patch("aurweb.config.get", side_effect=mock_config_get("none"))
|
|
def test_ratelimit_redis(get: mock.MagicMock, getboolean: mock.MagicMock,
|
|
getint: mock.MagicMock, pipeline: Pipeline):
|
|
""" This test will only cover aurweb.ratelimit's Redis
|
|
path if a real Redis server is configured. Otherwise,
|
|
it'll use the database. """
|
|
|
|
# We'll need a Request for everything here.
|
|
request = Request()
|
|
|
|
# Run check_ratelimit for our request_limit. These should succeed.
|
|
for i in range(4):
|
|
assert not check_ratelimit(request)
|
|
|
|
# This check_ratelimit should fail, being the 4001th request.
|
|
assert check_ratelimit(request)
|
|
|
|
# Delete the Redis keys.
|
|
host = request.client.host
|
|
pipeline.delete(f"ratelimit-ws:{host}")
|
|
pipeline.delete(f"ratelimit:{host}")
|
|
one, two = pipeline.execute()
|
|
assert one and two
|
|
|
|
# Should be good to go again!
|
|
assert not check_ratelimit(request)
|
|
|
|
|
|
@mock.patch("aurweb.config.getint", side_effect=mock_config_getint)
|
|
@mock.patch("aurweb.config.getboolean", side_effect=mock_config_getboolean(0))
|
|
@mock.patch("aurweb.config.get", side_effect=mock_config_get("none"))
|
|
def test_ratelimit_db(get: mock.MagicMock, getboolean: mock.MagicMock,
|
|
getint: mock.MagicMock, pipeline: Pipeline):
|
|
|
|
# We'll need a Request for everything here.
|
|
request = Request()
|
|
|
|
# Run check_ratelimit for our request_limit. These should succeed.
|
|
for i in range(4):
|
|
assert not check_ratelimit(request)
|
|
|
|
# This check_ratelimit should fail, being the 4001th request.
|
|
assert check_ratelimit(request)
|
|
|
|
# Delete the ApiRateLimit record.
|
|
with db.begin():
|
|
db.delete(db.query(ApiRateLimit).first())
|
|
|
|
# Should be good to go again!
|
|
assert not check_ratelimit(request)
|