mirror of
https://gitlab.archlinux.org/archlinux/aurweb.git
synced 2025-02-03 10:43:03 +01:00
a5943bf2ad
For SQLAlchemy to automatically understand updates from the
external world, it must use an `autocommit=True` in its session.
This change breaks how we were using commit previously, as
`autocommit=True` causes SQLAlchemy to commit when a
SessionTransaction context hits __exit__.
So, a refactoring was required of our tests: All usage of
any `db.{create,delete}` must be called **within** a
SessionTransaction context, created via new `db.begin()`.
From this point forward, we're going to require:
```
with db.begin():
db.create(...)
db.delete(...)
db.session.delete(object)
```
With this, we now get external DB modifications automatically
without reloading or restarting the FastAPI server, which we
absolutely need for production.
Signed-off-by: Kevin Morris <kevr@0cost.org>
60 lines
1.4 KiB
Python
60 lines
1.4 KiB
Python
import warnings
|
|
|
|
from datetime import datetime, timedelta
|
|
|
|
import pytest
|
|
|
|
from sqlalchemy import exc as sa_exc
|
|
|
|
from aurweb import db
|
|
from aurweb.db import create
|
|
from aurweb.models.ban import Ban, is_banned
|
|
from aurweb.testing import setup_test_db
|
|
from aurweb.testing.requests import Request
|
|
|
|
ban = request = None
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def setup():
|
|
global ban, request
|
|
|
|
setup_test_db("Bans")
|
|
|
|
ts = datetime.utcnow() + timedelta(seconds=30)
|
|
with db.begin():
|
|
ban = create(Ban, IPAddress="127.0.0.1", BanTS=ts)
|
|
request = Request()
|
|
|
|
|
|
def test_ban():
|
|
assert ban.IPAddress == "127.0.0.1"
|
|
assert bool(ban.BanTS)
|
|
|
|
|
|
def test_invalid_ban():
|
|
from aurweb.db import session
|
|
|
|
with pytest.raises(sa_exc.IntegrityError):
|
|
bad_ban = Ban(BanTS=datetime.utcnow())
|
|
|
|
# We're adding a ban with no primary key; this causes an
|
|
# SQLAlchemy warnings when committing to the DB.
|
|
# Ignore them.
|
|
with warnings.catch_warnings():
|
|
warnings.simplefilter("ignore", sa_exc.SAWarning)
|
|
with db.begin():
|
|
session.add(bad_ban)
|
|
|
|
# Since we got a transaction failure, we need to rollback.
|
|
db.rollback()
|
|
|
|
|
|
def test_banned():
|
|
request.client.host = "127.0.0.1"
|
|
assert is_banned(request)
|
|
|
|
|
|
def test_not_banned():
|
|
request.client.host = "192.168.0.1"
|
|
assert not is_banned(request)
|