aurweb/web/lib
Eli Schwartz d92dd69aa3 fix broken SQL query that always failed
Due to missing whitespace at the end of strings during joining, we ended
up with the query fragment

"DelTS IS NULLAND NOT PinnedTS"

which should be

"DelTS IS NULL AND NOT PinnedTS"

So the check for pinned comments > 5 likely always failed.

In php 7, a completely broken query that raises exceptions in the
database engine was silently ignored... in php 8, it raises

Uncaught PDOException: SQLSTATE[HY000]: General error: 1 near "PinnedTS": syntax error in <file>

and aborts the page building. End result: users with permission to pin
comments cannot see any comments, or indeed page content below the first
comment header

Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
2021-02-20 11:22:11 -05:00
..
acctfuncs.inc.php Fix more PHP 7.4 warnings 2020-02-13 09:11:34 +01:00
aur.inc.php Fix invalid session ID check 2020-04-05 15:59:55 -04:00
aurjson.class.php aurjson: use APCu/memcached for rate limiting 2019-11-02 18:32:07 -04:00
cachefuncs.inc.php Cache package provider and dependency information 2019-10-06 16:13:38 -04:00
confparser.inc.php confparser.inc.php: Add missing dollar sign 2018-05-12 12:37:16 +02:00
credentials.inc.php Move permission for LIST_COMMENTS to dev/tu block 2019-08-18 13:01:37 -04:00
DB.class.php Fix DB.class.php to match config and include SQLite support 2016-11-10 18:31:20 +01:00
feedcreator.class.php Avoid use of "<b>"/"</b>" 2012-09-24 12:23:05 +02:00
gettext.php Rename constructors to __construct 2016-01-28 22:55:32 +01:00
pkgbasefuncs.inc.php fix broken SQL query that always failed 2021-02-20 11:22:11 -05:00
pkgfuncs.inc.php pkg_search_page: Limit number of results on package search 2020-09-05 10:21:16 -04:00
pkgreqfuncs.inc.php Store timestamp and user ID when closing requests 2019-11-23 12:30:46 -05:00
routing.inc.php Add support for Terms of Service documents 2017-04-30 16:47:13 +02:00
stats.inc.php Handle empty resultset getting recent 10 packages 2018-03-21 07:45:26 +01:00
streams.php Rename constructors to __construct 2016-01-28 22:55:32 +01:00
timezone.inc.php Fix warning with invalid time zone 2017-02-27 18:20:00 +01:00
translator.inc.php Use native language name for Finnish 2019-05-24 12:37:08 -04:00
version.inc.php Release 5.0.0 2020-03-27 08:51:15 -04:00