external/yambar
1
0
Fork 1
mirror of https://codeberg.org/dnkl/yambar.git synced 2025-04-24 12:55:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

module/xkb: declare and initialize 'symbols' before first goto err

Browse source 
This ensures we don't free() an invalid value.
This commit is contained in:
Daniel Eklöf 2019-01-01 20:31:00 +01:00
parent a8a9ab28bd
commit c01806d6fa
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/xkb.c
View file

@ -143,6 +143,8 @@ get_layouts(xcb_connection_t *conn)
for (ssize_t i = 0; i < ret.count; i++) for (ssize_t i = 0; i < ret.count; i++)
group_name_cookies[i] = xcb_get_atom_name(conn, vlist.groups[i]); group_name_cookies[i] = xcb_get_atom_name(conn, vlist.groups[i]);
char *symbols = NULL;
/* Get layout short names (e.g. "us") */ /* Get layout short names (e.g. "us") */
xcb_get_atom_name_reply_t *atom_name = xcb_get_atom_name_reply( xcb_get_atom_name_reply_t *atom_name = xcb_get_atom_name_reply(
conn, symbols_name_cookie, &err); conn, symbols_name_cookie, &err);
@ -152,7 +154,7 @@ get_layouts(xcb_connection_t *conn)
goto err; goto err;
} }
char *symbols = strndup(xcb_get_atom_name_name(atom_name), symbols = strndup(xcb_get_atom_name_name(atom_name),
xcb_get_atom_name_name_length(atom_name)); xcb_get_atom_name_name_length(atom_name));
free(atom_name); free(atom_name);