pauljako/yambar
1
0
Fork 0
forked from external/yambar
Code Pull requests Activity

module/network: RTM_NEWLINK/DELLINK: don't do anything if nothing's changed

Browse source 
We're only interrested in a few of the attributes. Thus, there's no
need to log or update anything, if none of those attributes haven't
changed.
This commit is contained in:
Daniel Eklöf 2018-12-31 13:40:43 +01:00
parent dcf8051f1a
commit 24842d9b28
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
modules/network.c
View file

@ -242,7 +242,10 @@ handle_link(struct module *mod, uint16_t type,
switch (attr->rta_type) { switch (attr->rta_type) {
case IFLA_OPERSTATE: { case IFLA_OPERSTATE: {
uint8_t operstate = *(const uint8_t *)RTA_DATA(attr); uint8_t operstate = *(const uint8_t *)RTA_DATA(attr);
LOG_DBG("%s: IFLA_OPERSTATE: %hhu", m->iface, operstate); if (m->state == operstate)
break;
LOG_DBG("%s: IFLA_OPERSTATE: %hhu -> %hhu", m->iface, m->state, operstate);
mtx_lock(&mod->lock); mtx_lock(&mod->lock);
m->state = operstate; m->state = operstate;
@ -253,7 +256,10 @@ handle_link(struct module *mod, uint16_t type,
case IFLA_CARRIER: { case IFLA_CARRIER: {
uint8_t carrier = *(const uint8_t *)RTA_DATA(attr); uint8_t carrier = *(const uint8_t *)RTA_DATA(attr);
LOG_DBG("%s: IFLA_CARRIER: %hhu", m->iface, carrier); if (m->carrier == carrier)
break;
LOG_DBG("%s: IFLA_CARRIER: %hhu -> %hhu", m->iface, m->carrier, carrier);
mtx_lock(&mod->lock); mtx_lock(&mod->lock);
m->carrier = carrier; m->carrier = carrier;
@ -267,6 +273,9 @@ handle_link(struct module *mod, uint16_t type,
break; break;
const uint8_t *mac = RTA_DATA(attr); const uint8_t *mac = RTA_DATA(attr);
if (memcmp(m->mac, mac, sizeof(m->mac)) == 0)
break;
LOG_DBG("%s: IFLA_ADDRESS: %02x:%02x:%02x:%02x:%02x:%02x", LOG_DBG("%s: IFLA_ADDRESS: %02x:%02x:%02x:%02x:%02x:%02x",
m->iface, m->iface,
mac[0], mac[1], mac[2], mac[3], mac[4], mac[5]); mac[0], mac[1], mac[2], mac[3], mac[4], mac[5]);