From 70499654a3d05e044abc9c7436b6e9fe1050c151 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ekl=C3=B6f?= <daniel@ekloef.se>
Date: Wed, 6 Feb 2019 15:39:11 +0100
Subject: [PATCH] module/i3: delay bar refresh until all received events have
 been processed

This fixes an issue where switching between empty workspaces (or one
empty, one non-empty) momentarily flashed two workspaces.

I.e. we immediately rendered the new workspace, and then re-rendered
when the first workspace was destroyed.
---
 modules/i3.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/modules/i3.c b/modules/i3.c
index cce5ca3..a9963a4 100644
--- a/modules/i3.c
+++ b/modules/i3.c
@@ -504,6 +504,8 @@ run(struct module *mod)
         buf_idx += bytes;
 
         bool err = false;
+        bool need_bar_refresh = false;
+
         while (!err && buf_idx >= sizeof(i3_ipc_header_t)) {
             const i3_ipc_header_t *hdr = (const i3_ipc_header_t *)buf;
             if (strncmp(hdr->magic, I3_IPC_MAGIC, sizeof(hdr->magic)) != 0) {
@@ -551,12 +553,12 @@ run(struct module *mod)
 
             case I3_IPC_REPLY_TYPE_WORKSPACES:
                 handle_get_workspaces_reply(m, json);
-                mod->bar->refresh(mod->bar);
+                need_bar_refresh = true;
                 break;
 
             case I3_IPC_EVENT_WORKSPACE:
                 handle_workspace_event(m, json);
-                mod->bar->refresh(mod->bar);
+                need_bar_refresh = true;
                 break;
 
             case I3_IPC_EVENT_OUTPUT:
@@ -583,6 +585,9 @@ run(struct module *mod)
 
         if (err)
             break;
+
+        if (need_bar_refresh)
+            mod->bar->refresh(mod->bar);
     }
 
     free(buf);