pauljako/yambar
1
0
Fork 0
forked from external/yambar
Code Pull requests Activity

module/i3: avoid calling json_object_get_int() multiple times

Browse source
This commit is contained in:
Daniel Eklöf 2019-02-09 16:58:08 +01:00
parent 83db675e01
commit a3be2839e5
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
modules/i3.c
View file

@ -445,8 +445,8 @@ handle_window_event(struct private *m, const struct json_object *json)
free(ws->window.title);
ws->window.title = strdup(json_object_get_string(name));
const struct json_object *pid = json_object_object_get(container, "pid");
if (pid == NULL || !json_object_is_type(pid, json_type_int)) {
const struct json_object *pid_node = json_object_object_get(container, "pid");
if (pid_node == NULL || !json_object_is_type(pid_node, json_type_int)) {
LOG_ERR(
"'window' event (%s) did not contain a 'container.pid' integer value",
change_str);
@ -454,8 +454,9 @@ handle_window_event(struct private *m, const struct json_object *json)
}
/* If PID has changed, update application name from /proc/<pid>/comm */
if (ws->window.pid != json_object_get_int(pid)) {
ws->window.pid = json_object_get_int(pid);
pid_t pid = json_object_get_int(pid_node);
if (ws->window.pid != pid) {
ws->window.pid = pid;
char path[64];
snprintf(path, sizeof(path), "/proc/%u/comm", ws->window.pid);