forked from external/yambar
* Make sure to _exit() in all forked code paths that doesn't end in a successful exec() * Report errno to parent process on failure so that we can log it The second point is implemented by a) manually double forking instead of calling daemon(), and b) using a pipe in the inner fork to be able to wait for the child process to either succeed in its exec() call, or write errno to the pipe on failure. This fixes hangs and crashes when e.g. the binary we're trying to execute doesn't exist.
275 lines
7.8 KiB
C
275 lines
7.8 KiB
C
#include "particle.h"
|
|
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
#include <assert.h>
|
|
#include <errno.h>
|
|
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/wait.h>
|
|
#include <fcntl.h>
|
|
|
|
#define LOG_MODULE "particle"
|
|
#define LOG_ENABLE_DBG 0
|
|
#include "log.h"
|
|
#include "bar/bar.h"
|
|
|
|
void
|
|
particle_default_destroy(struct particle *particle)
|
|
{
|
|
if (particle->deco != NULL)
|
|
particle->deco->destroy(particle->deco);
|
|
font_destroy(particle->font);
|
|
free(particle->on_click_template);
|
|
free(particle);
|
|
}
|
|
|
|
struct particle *
|
|
particle_common_new(int left_margin, int right_margin,
|
|
const char *on_click_template,
|
|
struct font *font, struct rgba foreground,
|
|
struct deco *deco)
|
|
{
|
|
struct particle *p = calloc(1, sizeof(*p));
|
|
p->left_margin = left_margin;
|
|
p->right_margin = right_margin;
|
|
p->on_click_template =
|
|
on_click_template != NULL ? strdup(on_click_template) : NULL;
|
|
p->foreground = foreground;
|
|
p->font = font;
|
|
p->deco = deco;
|
|
return p;
|
|
}
|
|
|
|
void
|
|
exposable_default_destroy(struct exposable *exposable)
|
|
{
|
|
free(exposable->on_click);
|
|
free(exposable);
|
|
}
|
|
|
|
void
|
|
exposable_render_deco(const struct exposable *exposable,
|
|
cairo_t *cr, int x, int y, int height)
|
|
{
|
|
const struct deco *deco = exposable->particle->deco;
|
|
if (deco != NULL)
|
|
deco->expose(deco, cr, x, y, exposable->width, height);
|
|
|
|
}
|
|
|
|
static bool
|
|
push_argv(char ***argv, size_t *size, char *arg, size_t *argc)
|
|
{
|
|
if (arg != NULL && arg[0] == '%')
|
|
return true;
|
|
|
|
if (*argc >= *size) {
|
|
size_t new_size = *size > 0 ? 2 * *size : 10;
|
|
char **new_argv = realloc(*argv, new_size * sizeof(new_argv[0]));
|
|
|
|
if (new_argv == NULL)
|
|
return false;
|
|
|
|
*argv = new_argv;
|
|
*size = new_size;
|
|
}
|
|
|
|
(*argv)[(*argc)++] = arg;
|
|
return true;
|
|
}
|
|
|
|
static bool
|
|
tokenize_cmdline(char *cmdline, char ***argv)
|
|
{
|
|
*argv = NULL;
|
|
size_t argv_size = 0;
|
|
|
|
bool first_token_is_quoted = cmdline[0] == '"' || cmdline[0] == '\'';
|
|
char delim = first_token_is_quoted ? cmdline[0] : ' ';
|
|
|
|
char *p = first_token_is_quoted ? &cmdline[1] : &cmdline[0];
|
|
|
|
size_t idx = 0;
|
|
while (*p != '\0') {
|
|
char *end = strchr(p, delim);
|
|
if (end == NULL) {
|
|
if (delim != ' ') {
|
|
LOG_ERR("unterminated %s quote\n", delim == '"' ? "double" : "single");
|
|
free(*argv);
|
|
return false;
|
|
}
|
|
|
|
if (!push_argv(argv, &argv_size, p, &idx) ||
|
|
!push_argv(argv, &argv_size, NULL, &idx))
|
|
{
|
|
goto err;
|
|
} else
|
|
return true;
|
|
}
|
|
|
|
*end = '\0';
|
|
|
|
if (!push_argv(argv, &argv_size, p, &idx))
|
|
goto err;
|
|
|
|
p = end + 1;
|
|
while (*p == delim)
|
|
p++;
|
|
|
|
while (*p == ' ')
|
|
p++;
|
|
|
|
if (*p == '"' || *p == '\'') {
|
|
delim = *p;
|
|
p++;
|
|
} else
|
|
delim = ' ';
|
|
}
|
|
|
|
if (!push_argv(argv, &argv_size, NULL, &idx))
|
|
goto err;
|
|
|
|
return true;
|
|
|
|
err:
|
|
free(*argv);
|
|
return false;
|
|
}
|
|
|
|
void
|
|
exposable_default_on_mouse(struct exposable *exposable, struct bar *bar,
|
|
enum mouse_event event, int x, int y)
|
|
{
|
|
LOG_DBG("on_mouse: exposable=%p, event=%s, x=%d, y=%d", exposable,
|
|
event == ON_MOUSE_MOTION ? "motion" : "click", x, y);
|
|
|
|
/* If we have a handler, change cursor to a hand */
|
|
bar->set_cursor(bar, exposable->on_click == NULL ? "left_ptr" : "hand2");
|
|
|
|
/* If this is a mouse click, and we have a handler, execute it */
|
|
if (exposable->on_click != NULL && event == ON_MOUSE_CLICK) {
|
|
/* Need a writeable copy, whose scope *we* control */
|
|
char *cmd = strdup(exposable->on_click);
|
|
LOG_DBG("cmd = \"%s\"", exposable->on_click);
|
|
|
|
char **argv;
|
|
if (!tokenize_cmdline(cmd, &argv)) {
|
|
free(cmd);
|
|
return;
|
|
}
|
|
|
|
pid_t pid = fork();
|
|
if (pid == -1)
|
|
LOG_ERRNO("failed to run on_click handler (fork)");
|
|
else if (pid > 0) {
|
|
/* Parent */
|
|
free(cmd);
|
|
free(argv);
|
|
|
|
int wstatus;
|
|
if (waitpid(pid, &wstatus, 0) == -1)
|
|
LOG_ERRNO("%s: failed to wait for on_click handler", exposable->on_click);
|
|
|
|
if (WIFEXITED(wstatus)) {
|
|
if (WEXITSTATUS(wstatus) != 0)
|
|
LOG_ERRNO_P("%s: failed to execute", WEXITSTATUS(wstatus), exposable->on_click);
|
|
} else
|
|
LOG_ERR("%s: did not exit normally", exposable->on_click);
|
|
|
|
LOG_DBG("%s: launched", exposable->on_click);
|
|
} else {
|
|
/*
|
|
* Use a pipe with O_CLOEXEC to communicate exec() failure
|
|
* to parent process.
|
|
*
|
|
* If the child succeeds with exec(), the pipe is simply
|
|
* closed. If it fails, we write the fail reason (errno)
|
|
* to the pipe. The parent reads the pipe; if it receives
|
|
* data, the child failed, else it succeeded.
|
|
*/
|
|
int pipe_fds[2];
|
|
if (pipe2(pipe_fds, O_CLOEXEC) == -1) {
|
|
LOG_ERRNO("%s: failed to create pipe", cmd);
|
|
free(cmd);
|
|
return;
|
|
}
|
|
|
|
LOG_DBG("ARGV:");
|
|
for (size_t i = 0; argv[i] != NULL; i++)
|
|
LOG_DBG(" #%zu: \"%s\" ", i, argv[i]);
|
|
|
|
LOG_DBG("double forking");
|
|
|
|
switch (fork()) {
|
|
case -1:
|
|
close(pipe_fds[0]);
|
|
close(pipe_fds[1]);
|
|
|
|
LOG_ERRNO("failed to double fork");
|
|
_exit(errno);
|
|
break;
|
|
|
|
case 0:
|
|
/* Child */
|
|
close(pipe_fds[0]); /* Close read end */
|
|
|
|
LOG_DBG("executing on-click handler: %s", cmd);
|
|
|
|
/* Redirect stdin/stdout/stderr to /dev/null */
|
|
int dev_null_r = open("/dev/null", O_RDONLY | O_CLOEXEC);
|
|
int dev_null_w = open("/dev/null", O_WRONLY | O_CLOEXEC);
|
|
|
|
if (dev_null_r == -1 || dev_null_w == -1) {
|
|
LOG_ERRNO("/dev/null: failed to open");
|
|
write(pipe_fds[1], &errno, sizeof(errno));
|
|
_exit(1);
|
|
}
|
|
|
|
if (dup2(dev_null_r, STDIN_FILENO) == -1 ||
|
|
dup2(dev_null_w, STDOUT_FILENO) == -1 ||
|
|
dup2(dev_null_w, STDERR_FILENO) == -1)
|
|
{
|
|
LOG_ERRNO("failed to redirect stdin/stdout/stderr");
|
|
write(pipe_fds[1], &errno, sizeof(errno));
|
|
_exit(1);
|
|
}
|
|
|
|
execvp(argv[0], argv);
|
|
|
|
/* Signal failure to parent process */
|
|
write(pipe_fds[1], &errno, sizeof(errno));
|
|
_exit(1);
|
|
break;
|
|
|
|
default:
|
|
/* Parent */
|
|
close(pipe_fds[1]); /* Close write end */
|
|
|
|
int _errno = 0;
|
|
ssize_t ret = read(pipe_fds[0], &_errno, sizeof(_errno));
|
|
if (ret == 0) {
|
|
/* Pipe was closed - child succeeded with exec() */
|
|
_exit(0);
|
|
}
|
|
|
|
LOG_DBG("second pipe failed", _errno);
|
|
_exit(_errno);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
struct exposable *
|
|
exposable_common_new(const struct particle *particle, const char *on_click)
|
|
{
|
|
struct exposable *exposable = calloc(1, sizeof(*exposable));
|
|
exposable->particle = particle;
|
|
exposable->on_click = on_click != NULL ? strdup(on_click) : NULL;
|
|
exposable->destroy = &exposable_default_destroy;
|
|
exposable->on_mouse = &exposable_default_on_mouse;
|
|
return exposable;
|
|
}
|