use the logging module instead of writing directly to stderr
this makes the code cleaner as it removes the numerous tests for the value
of DBUG, yet allows devs to control the level of output verbosity.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
- remove need to use mysql for escaping the sql -- removing single quote
should be enough
- instead of using sql to fetch categories from a live database, simply
consider categories an integer range, specified to the size of that in the
aur-schema.
Lukas: Add "CATEGORIES_COUNT" initialization. Fix random number range
used in genCategory() (AUTO_INCREMENT columns are 1-based by default,
not 0-based).
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
This simplifies instructions for translators and allows them to have an
out of the box working configuration.
Signed-off-by: Dan McGee <dan@archlinux.org>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Use `rm -f` instead of just `rm` here to supress those annoying warnings
about failed removal if either ".po~" backup files or compiled ".mo"
files are missing.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
This ensures we have proper native portable objects instead of those
created by sed(1)'ing the former translation files.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Those can be used as a shortcut to msgmerge(1) to update one
("$locale.po-update") or all ("update-po") portable object files with
new strings from the message catalog ("aur.pot").
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Those are just dummy headers created by ripping them off from "aur.pot"
and changing the "Content-Type" charset to UTF-8.
Needed to make msgmerge(1) operate on our converted ".po" files -
otherwise it would fail to detect the files' encodings and do nothing
but throw a pile of "invalid multibyte sequence" errors.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Can be used to rebuild the message catalog from our source tree.
"po/POTFILES" contains a list of source files to be scanned for
translation strings.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Those legacy ".po" files and translation helpers are no longer needed as
we moved to gettext compatible portable objects.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Put new gettext compatible files into "po/" while keeping old
translations in "web/lang/".
Conversion was done using following hacky shell script:
----
for f in *.po; do
# Remove "<?php" shebang and "global" statements.
sed -i '1d; /^global/d' "$f"
# Convert former translation strings into real PO statements.
sed -i 's/^$_t\[\(.*\)\] = \(.*\);.*/msgid \1\nmsgstr \2/' "$f"
# Ensure there always is an empty line after each msgstr.
sed -i '/^msgstr/!b; n; /^$/!i\
' "$f"
done
----
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Do this in preparation for converting exisiting translation files into
gettext compatible ones. Newlines will he hard to match by a conversion
script.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
* Translation of "notify" has been changed to the literal translation
"notifier" which seems more appropriate (cf. recent thread on
AUR-general)
* Uniformization of the translation of "flag"
* Addition of "TU" besides the translation of Trusted User as user may
not understand that Trusted User and "Utilisateur de confiance" are
the same thing
* Some capitalization correction (in French you don't put capital
letters in the middle of a sentence as you do eg for title in
English).
* "unsupported" translation has been replaced by "unsupported" (with
quotes) as it makes no sense to translate it
* "Safe" translation has been replaced by "sûr" has it seems more
appropriate than "sain" (sane)
Lukas: Added translator to "AUTHORS".
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Ensures "$name" is always initialized, even if the package doesn't
exist. Fixes PHP warnings appearing when retrieving package details of a
package with an invalid ID.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
We removed the code depending on this a long time ago - drop it and add
some note to "UPGRADING".
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Instead, we just store dependencies directly in the PackageDepends
table. Since we don't use this info anywhere besides the package details
page, there is little value in precalculating what is in the AUR vs.
what is not.
An upgrade path is provided via several SQL statements in the UPGRADING
document. There should be no user-visible change from this, but the DB
schema gets a bit more sane and we no longer have loads of junk packages
in our tables that are never shown to the end user. This should also
help the MySQL query planner in several cases as we no longer have to be
careful to exclude dummy packages on every query.
Signed-off-by: Dan McGee <dan@archlinux.org>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
Set it equal to the SubmittedTS field, which will be our indication the
package is new when we show the logo on the front page of the AUR.
This results in the ability to remove the use of the unindexable
GREATEST() function from the AUR code everywhere we had to use it before
to handle the 0 timestamp case.
Note that there is no race condition here in calling UNIX_TIMESTAMP()
twice- it always returns the time at the beginning of statment
execution:
mysql> select unix_timestamp(), sleep(2), unix_timestamp();
+------------------+----------+------------------+
| unix_timestamp() | sleep(2) | unix_timestamp() |
+------------------+----------+------------------+
| 1300851746 | 0 | 1300851746 |
+------------------+----------+------------------+
1 row in set (2.00 sec)
Signed-off-by: Dan McGee <dan@archlinux.org>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
We had a ton of duplicate code shared between the insert and update
cases. Do a refactor so we can pull this stuff out below the if/else
block and only need it there once, saving some headaches.
Signed-off-by: Dan McGee <dan@archlinux.org>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
end() expects a reference but we pass a function return value here.
Using list() is a bit hacky as well as it expects a 0-based array
whereas unpack() returns a 1-based array - thus we use "list(, $foo)".
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
This is quite hacky but this way we can ensure users get comprehensible
error messages when trying to upload ".tar.xz" or ".tar.bz2" files.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
25 is woefully small for the number of packages many searches can
return, and with 28000+ packages in AUR, it makes sense to show a lot
more per page by default.
The new choices of (50, 100, 250) happen to match those from the main
site.
Signed-off-by: Dan McGee <dan@archlinux.org>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
I've been wanting to kill this one for a long time.
Signed-off-by: Dan McGee <dan@archlinux.org>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
