Commit graph

3426 commits

Author SHA1 Message Date
Kevin Morris
b49aa79c2c Merge branch 'tu_vote_decision' into 'master'
Allow Trusted Users to change their proposal decisions

See merge request archlinux/aurweb!477
2022-03-08 08:03:28 +00:00
Kevin Morris
e2a17fef95
upgrade: bump to v6.0.22
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-03-07 23:57:54 -08:00
Kevin Morris
0f0a2f18ad
Merge branch 'copy-fix' 2022-03-07 23:55:23 -08:00
Kevin Morris
5045f0f3e4
fix: copy.js javascript initialization
Not sure where this works, but it doesn't seem to work on my
browser. Achieved the same by forEaching through the array
returned by querySelectorAll instead.

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-03-07 23:53:57 -08:00
Kevin Morris
f11e8de251
upgrade: bump to v6.0.21
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-03-07 23:32:14 -08:00
Kevin Morris
6a243e90db
fix: only reject addvote for users with running proposals
This was incorrectly indiscriminately targetting _any_ proposal
for a particular user.

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-03-07 23:23:49 -08:00
Kevin Morris
9e3c2e15ea
feat: allow TUs to change their votes on running proposals
In addition, this patch brings in display for the vote decision
you cast on it. This is only viewable by the request user; your
vote is not being shared with others.

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-03-07 23:13:08 -08:00
Kevin Morris
cf4ab696d0
test: update tests to work with TUVote.Decision
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-03-07 22:35:59 -08:00
Kevin Morris
a29701459c
feat: add Decision column to TUVote
In preparation for allowing TUs to change their votes on proposals,
we need a way to track what users vote for.

Without this, the vote decisions are stored within the related
TU_VoteInfo record, decoupled from the user who made the vote.

That being the case meant we cannot actually change a vote, because
we can't figure out what TU_VoteInfo decision columns to decrement
when the vote has changed.

You may be wondering why we aren't removing the decision columns out
of TU_VoteInfo with the advent of this new column. The reason being:
previous votes are all calculated off of the TU_VoteInfo columns, so
without a manual DB rework, relocating them to the user-related vote
records would break outcomes of old proposals. So, the plan is:
we'll solely use this column for votes from this point on to track
what decision a user made internally, which will open up TUs changing
their decision.

In addition, this migration resets all running proposals:
- all votes are deleted
- time is reset to Start when migration is run

This was necessary to put running proposals into a state that can
take advantage of the new revote system.

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-03-07 22:35:52 -08:00
Matt Harrison
b80d914cba
fix click to copy when there is more than one copy link on the page.
Fixes issue reported on the mailing list here: https://lists.archlinux.org/pipermail/aur-general/2022-March/036833.html

Thanks to Henry-Joseph Audéoud for diagnosing the issue
https://lists.archlinux.org/pipermail/aur-general/2022-March/036836.html

Also update the event variable to use the local copy instead of the
deprecated global version
https://stackoverflow.com/questions/58341832/event-is-deprecated-what-should-be-used-instead
2022-03-07 12:37:54 -05:00
Kevin Morris
c7c79a152b
upgrade: bump to v6.0.20
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-25 19:44:10 -08:00
Kevin Morris
95c191fb31
Merge branch 'master' of ssh://gitlab.archlinux.org:222/archlinux/aurweb 2022-02-25 19:31:24 -08:00
Kevin Morris
9204b76110
fix: ...do not add to ActiveTUs when voting on a proposal
Straight up bug.

Closes #324

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-25 19:28:03 -08:00
Kevin Morris
1bb4daa36a
doc: merge CodingGuidelines into CONTRIBUTING.md
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-23 18:54:35 -08:00
Kevin Morris
25d74d02c7
Merge remote-tracking branch 'fosskers/colin/docker-usage' 2022-02-23 18:24:58 -08:00
Colin Woodbury
d92f183840
docs(docker): explain how to generate dummy data 2022-02-23 18:12:49 -08:00
Kevin Morris
b63ac7ce91
Merge remote-tracking branch 'fosskers/colin/contributing-tweak' 2022-02-23 17:00:05 -08:00
Kevin Morris
07e479ab50
upgrade: bump to v6.0.19
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-23 14:37:41 -08:00
Kevin Morris
51d4b7f993
fix(rpc): limit Package results, not relationships
...This was an obvious bug in hindsight. Apologies :(

Closes #314

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-23 14:17:41 -08:00
Colin Woodbury
27f30212e8
docs(docker): note ports and curl usage 2022-02-21 14:40:18 -08:00
Colin Woodbury
7c36379715
docs(docker): basic usage instructions 2022-02-21 14:18:26 -08:00
Colin Woodbury
9f452a62e5
docs: fix link formatting in CONTRIBUTING 2022-02-21 11:56:57 -08:00
Kevin Morris
1e31db47ab
upgrade: bump to v6.0.18
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-19 16:32:49 -08:00
Kevin Morris
80622cc966
fix: suspend check should check Suspended...
This was causing some false negative errors in the update process,
and it clearly not correct -- oops :(

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-19 16:26:31 -08:00
Kevin Morris
4a4fd01563
fix: blanking out particular fields when editing accounts
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-19 16:01:06 -08:00
Kevin Morris
c83c5cdc42
change: log out details about PROMETHEUS_MULTIPROC_DIR
Additionally, respond with a 503 if the var is not set when
/metrics is requested.

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-19 12:08:55 -08:00
Kevin Morris
388e64d0af
upgrade: bump to v6.0.17
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-18 17:54:36 -08:00
Kevin Morris
7cc20cd9a4
fix: suspended users should not be able to login
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-18 17:50:35 -08:00
Kevin Morris
e43e1c6d20
upgrade: bump to v6.0.16
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-18 17:17:14 -08:00
Kevin Morris
14347232fd
fix: treat all keywords as lowercase when updating
In addition, treat package search by keywords as lowercase.

Closes #296, #297, #298, #301

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-18 16:58:02 -08:00
Kevin Morris
8387f325f6
fix: resolve null VoteTS columns via migration
Somehow, many aur.al records of PackageVotes do not have a valid VoteTS
value. This migration fixes that issue by setting all null VoteTS
columns to the epoch timestamp.

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-18 16:16:07 -08:00
Kevin Morris
1d86b3e210
fix: use a transaction for package query; remove refresh
Closes #284

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-18 15:58:42 -08:00
Kevin Morris
4e641d945c
fix: unset InactivityTS for users on login
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-18 13:53:45 -08:00
Kevin Morris
b2508e5bf8
upgrade: bump to v6.0.15
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-17 18:27:00 -08:00
Kevin Morris
dcaf407536
fix: /packages search result count
We need to query for this after we've applied all filters.

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-17 17:55:02 -08:00
Kevin Morris
bfd592299c
change: display default package search parameter values in its form
The previous behavior was carried over from PHP. It has been requested
that we use the true defaults when rendering the default form, making
search a bit more sensible.

Closes #269

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-17 17:54:57 -08:00
Kevin Morris
0bfecb9844
upgrade: bump to v6.0.14
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-17 16:14:31 -08:00
Kevin Morris
2fd9f3436d
Merge branch 'fix-request-autogen' 2022-02-17 16:08:18 -08:00
Kevin Morris
e3864d4b7c
fix: set RequestTS when autogenerating requests
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-17 15:54:04 -08:00
Kevin Morris
361163098f
fix: /packages search ordering links
This was not including other parameters that should be persisted for
users.

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-17 15:49:41 -08:00
Kevin Morris
040c9bc3e6
fix: send up to date flag notifications
These were being produced with the db state before the flag was set,
which is not what should be done for flag notifications, as the
notification contains data about the comment and the current flagger.

Closes #292

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-17 15:30:32 -08:00
Kevin Morris
640630faff
upgrade: bump to v6.0.13
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-14 15:45:59 -08:00
Kevin Morris
da0e74a648
Merge branch 'master' of ssh://gitlab.archlinux.org:222/archlinux/aurweb 2022-02-14 15:43:37 -08:00
Kevin Morris
9327594926
upgrade: bump to v6.0.12
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-14 15:42:18 -08:00
Kevin Morris
29061c000c
fix: pkgbase -> package redirection
We were redirecting in some error-cases, which this commit sorts out:
- package count == 1 and package base name != package name
- was redirecting to {name} and not the only associated Package

Now, when we have a package base name that mismatches its only
package, we display the package base page. Otherwise, we redirect
to the first package's page.

Closes #282

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-14 15:38:00 -08:00
Kevin Morris
1671868956
fix: links to cgit should be url encoded
Closes #283

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-13 17:44:40 -08:00
Kevin Morris
708ade4dbf
fix: allow co-maintainers to [un]pin comments on a package
Closes #279

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-11 16:24:42 -08:00
Kevin Morris
35e7486ea3
upgrade: bump to v6.0.11
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-11 00:50:34 -08:00
Kevin Morris
50b726d739
fix: send notifications when users submit comments
Closes #278

Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-11 00:43:50 -08:00
Kevin Morris
a2e993119e
fix: correct typo in Bug.md
Signed-off-by: Kevin Morris <kevr@0cost.org>
2022-02-10 14:52:03 -08:00