Commit graph

1415 commits

Author SHA1 Message Date
Lukas Fleischer
cc490ce8d6 passreset.php: Error out if e-mail is empty
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2014-01-11 12:08:24 +01:00
Lukas Fleischer
48b74071f0 passreset.php: Refactor HTML
* Use the "errorlist" class for errors.
* Refactor some code.
* Properly display error messages when requesting a key.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2014-01-11 12:08:24 +01:00
Joris Steyn
72e4d54178 Typeahead workaround for having to press enter twice
Currently, one has to press enter twice in order to submit the package
search form with typeahead completion. Add a workaround to fix this.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2014-01-11 12:04:33 +01:00
Joris Steyn
0d68494de7 Go to package when selecting a typeahead suggestion
Directly jump to the package details when selecting an entry from the
drop-down list.

Implements FS#34471.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2014-01-02 00:48:20 +01:00
canyonknight
dbf1d474f7 Convert adopt/disown package action link to form
* Changes adopting/disowning packages to use GET instead of POST
* Uses CSS to make form submit button look like a link
* Complements commit 3bc951e3d8

Signed-off-by: canyonknight <canyonknight@gmail.com>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-09-08 13:53:47 +02:00
Lukas Fleischer
77f1b264ca Sync CSS with archweb
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-09-03 13:14:39 +02:00
Lukas Fleischer
54ad28369a tu_list.php: Hide table if no results are found
Instead of showing a table with a single "No results found." entry, do
not show the table at all and display the text "No results found." in a
<p></p> container.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-09-03 12:58:54 +02:00
Lukas Fleischer
3130a887e8 Move "Add Proposal" link to "Current Votes"
The page this links to allows for adding an item to the list of current
votes. Move the link accordingly.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-09-03 12:53:58 +02:00
Lukas Fleischer
40fd73b668 Release 2.3.0
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-09-02 13:26:33 +02:00
Lukas Fleischer
f69facc9c9 Translation updates from Transifex
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-09-02 13:25:46 +02:00
Chris Down
35c5a5a3a9 Specify charset in Content-Type header when returning JSON data from API.
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-09-02 00:29:58 +02:00
Lukas Fleischer
d225366f31 Add a registration time stamp to the "Users" table
This allows for easily detecting old accounts that registered and never
used the confirmation e-mail to set an initial password.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-28 16:37:56 +02:00
Lukas Fleischer
2276171b29 Only include current TUs in the last votes list
Do not show users that took part in past TU votes but no longer have TU
powers. Also, fix the sorting column while we're touching these lines.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-28 01:52:40 +02:00
Lukas Fleischer
c1c7f9b350 Move package comment check to packages.php
Checking whether to add a comment is something that really does not
belong to a function named display_package_details().

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-27 11:35:26 +02:00
Lukas Fleischer
bf019a5b6c Use POST-Redirect-GET for most package actions
Avoid showing a POST data resubmission dialog and simply redirect to the
package page if a package action completed successfully.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-27 11:25:14 +02:00
Lukas Fleischer
23867a211c Add boolean return values to several pkg_*() functions
Change the return values of following functions to return both
error/success and an error/success message:

* pkg_flag()
* pkg_unflag()
* pkg_adopt()
* pkg_vote()
* pkg_delete()
* pkg_notify()
* pkg_delete_comment()
* pkg_change_category()

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-27 11:19:45 +02:00
Lukas Fleischer
86d2efaaa0 Exclude running votes from "Last Votes by TU"
Showing running votes potentially allows for tracking votes and
associating yes/no/abstain votes with specific TUs.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-27 10:52:38 +02:00
Lukas Fleischer
7b0495cee2 Add a "fonts" package category
Implements FS#34666.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-27 02:46:55 +02:00
Lukas Fleischer
7c8e86010d Pick sane default registration language
Instead of defaulting to Català (which is the first entry in the list of
supported languages), choose whatever language the unregistered user is
browsing the AUR in.

Fixes FS#34825.

Suggested-by: canyonknight <canyonknight@gmail.com>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-27 02:42:19 +02:00
Lukas Fleischer
69b98efa35 Re-add CRSF tokens to most package actions
We fixed all known CRSF vulnerabilities in commit 2c93f0a (Implement
token system to fix CSRF vulnerabilities, 2012-06-23). c349cb2 (Add
virtual path support for package actions, 2012-07-17) partly reverted
this by injecting a valid CRSF token when virtual paths are in use.

This patch allows for keeping the virtual path feature, while
reintroducing POST forms and CRSF tokens. Actions like package flagging,
votes and notifications are no longer prone to CRSF (see FS#35437 for
details).

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-27 02:27:19 +02:00
Lukas Fleischer
3bc951e3d8 pkg_details: Convert most action links to forms
Use forms and POST instead of GET for following actions:

* Flagging/Unflagging a package out-of-date
* Voting for a package and removing votes
* Enabling/Disabling notifications

Use CSS to make the submit buttons of these forms look like links.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-27 02:10:13 +02:00
Lukas Fleischer
be80aa0f01 Add Japanese and Slovak languages
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-26 18:45:10 +02:00
Lukas Fleischer
924da81e64 Update Transifex URL
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-26 18:37:24 +02:00
Lukas Fleischer
d7c8026781 Update message catalog
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-26 18:35:58 +02:00
Lukas Fleischer
431bf2f2f3 tu_details.php: Avoid division by zero
Do not divide by zero if the number of active TUs is unknown.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-26 18:02:37 +02:00
Lukas Fleischer
a4a170e58e Move "Past Votes" navigation to "Past Votes" box
These are navigation links and do not belong to the action box.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-26 17:53:24 +02:00
Lukas Fleischer
2dd3d04f45 Add "Last Votes by TU" list
This shows a list of all Trusted Users and the vote ID of the last
proposal each of the TUs voted on. This list is sorted by vote ID.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-26 17:34:31 +02:00
Lukas Fleischer
fb76aab8cf tu_details.php: Display vote result
This adds an field that indicates whether the vote was accepted or
rejected, based on the rules specified in the TU Bylaws.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-22 17:48:18 +02:00
Lukas Fleischer
481ff2335c tu_details.php: Avoid inline computations
Compute the total number of votes and the participation at the beginning
of the template instead of doing it inside the template itself.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-22 17:48:18 +02:00
Lukas Fleischer
d41e40d9d6 Add a vote type to the TU proposal form
There are only four valid reasons for starting a TU vote, so instead of
letting the user choose a vote length, let her pick a reason and set
vote length and quorum based on that selection.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-22 17:48:18 +02:00
Lukas Fleischer
64bfa6e828 Add a quorum column to TU_VoteInfo
This allows for specifying a quorum per vote and sets a basis for
implementing automated acceptance/rejection of TU votes later.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-22 17:48:16 +02:00
Lukas Fleischer
86fa42f399 Show participation in vote details
This is calculated by dividing the sum of all votes by the total number
of TUs (where the number of TUs is measured when the vote starts).

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-22 17:47:53 +02:00
Lukas Fleischer
9ff082be25 Store the number of TUs when starting a vote
This will be used for automated calculation of vote participation later.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-22 17:47:51 +02:00
Lukas Fleischer
6844f6c1d2 Allow for setting an account's inactivity status
This adds a field to the users table and corresponding fields to the
account edit and display forms that allow for setting an (in-)activity
status.

This might turn out to be useful if a user is on vacation and can not
respond to update/orphan/deletion requests.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-22 17:43:13 +02:00
Lukas Fleischer
6ecfe12ce2 Merge branch 'maint' 2013-08-17 21:36:39 +02:00
Lukas Fleischer
95df5e4503 Release 2.2.1
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-17 21:35:56 +02:00
Lukas Fleischer
4bba2672cf Merge branch 'maint' 2013-08-17 19:54:34 +02:00
Dave Reisner
5abd366547 Upgrade Archive/Tar from PEAR to work with php 5.5
This resolves issues with backwards incompatible changes to
pack/unpack in php 5.5:

http://www.php.net/manual/de/migration55.incompatible.php

Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-17 19:51:51 +02:00
Lukas Fleischer
f0e2c399df aurblup: Update for pacman 4.1 API changes
alpm_db_register_sync() and alpm_option_get_syncdbs() have been renamed.
Update aurblup sources accordingly.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-08-17 18:24:21 +02:00
Lukas Fleischer
6b1ba5e48f aurblup: Update for pacman 4.1 API changes
alpm_db_register_sync() and alpm_option_get_syncdbs() have been renamed.
Update aurblup sources accordingly.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-04-28 13:44:32 +02:00
canyonknight
cf083cf9ba Remove superfluous search wrapper function
The search_accounts_form() wrapper function doesn't have any
arguments and only makes it unclear what is happening within
account.php

Signed-off-by: canyonknight <canyonknight@gmail.com>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-04-24 11:05:51 +02:00
canyonknight
ca067d5492 Retrieve package details after package actions are processed
Fixes FS#34508

Signed-off-by: canyonknight <canyonknight@gmail.com>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-04-20 00:22:53 +02:00
Lukas Fleischer
f542383bc5 Release 2.2.0
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-03-26 07:28:23 +01:00
Lukas Fleischer
504747e106 Translation updates from Transifex
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-03-26 07:27:47 +01:00
Lukas Fleischer
0703b02c53 Use minified typeahead JS from archweb
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-03-26 00:54:18 +01:00
Lukas Fleischer
50849ccbdc Update message catalog
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-03-25 02:20:07 +01:00
Lukas Fleischer
cd59a313b4 Show hint if password is empty during login
A user might have an empty password due to two reasons:

* The user just created an account and needs to set an initial password.
* The password has been reset by the administrator.

In both cases, the user might be confused as to why the login does not
work. Add a message that helps users debug the issue in both cases.

Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-03-25 02:15:12 +01:00
Lukas Fleischer
589f506aaa Update message catalog
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-03-24 22:25:29 +01:00
canyonknight
cb91942595 Implement IP banning for user registration and user login
Adds a new is_ipbanned() function to determine whether the user
attempting to login or register for an account has their IP
address listed in the "Bans" table.

Signed-off-by: canyonknight <canyonknight@gmail.com>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-03-24 22:12:17 +01:00
canyonknight
de2392fed0 Add "Bans" table to database schema
The "Bans" table creates a DB structure for the ability to ban IP
addresses. It takes an IP address converted by ip2long().

The table will eventually be able to be populated directly through
the web interface by Trusted Users and Developers.

Signed-off-by: canyonknight <canyonknight@gmail.com>
Signed-off-by: Lukas Fleischer <archlinux@cryptocrack.de>
2013-03-24 22:12:08 +01:00